Enforce clang-format formatting on all JS files

This change reformats all files according to clang-format rules (the
same that Angular JS has) and forces the files to comply with the
formatting.

Author: bryk

.clang-format

@@ -0,0 +1,5 @@
+# Project configuration for the clang-format tool.
+# Learn more at: http://clang.llvm.org/docs/ClangFormat.html
+Language:        JavaScript
+BasedOnStyle:    Google
+ColumnLimit:     100

build/backend.js

@@ -28,13 +28,16 @@ import goCommand from './gocommand';
  * directory.
  */
 gulp.task('backend', function(doneFn) {
-  goCommand([
-    'build',
-    // Install dependencies to speed up subsequent compilations.
-    '-i',
-    '-o', path.join(conf.paths.serve, conf.backend.binaryName),
-    conf.backend.packageName,
-  ], doneFn);
+  goCommand(
+      [
+        'build',
+        // Install dependencies to speed up subsequent compilations.
+        '-i',
+        '-o',
+        path.join(conf.paths.serve, conf.backend.binaryName),
+        conf.backend.packageName,
+      ],
+      doneFn);
 });
 
 
@@ -50,20 +53,24 @@ gulp.task('backend:prod', function(doneFn) {
 
   // Delete output binary first. This is required because prod build does not override it.
   del(outputBinaryPath)
-      .then(function() {
-        goCommand([
-          'build',
-          '-a',
-          '-installsuffix', 'cgo',
-          '-o', outputBinaryPath,
-          conf.backend.packageName,
-        ], doneFn, {
-          // Disable cgo package. Required to run on scratch docker image.
-          CGO_ENABLED: '0',
-          // Scratch docker image is linux.
-          GOOS: 'linux',
-        });
-      }, function(error) {
-        doneFn(error);
-      });
+      .then(
+          function() {
+            goCommand(
+                [
+                  'build',
+                  '-a',
+                  '-installsuffix',
+                  'cgo',
+                  '-o',
+                  outputBinaryPath,
+                  conf.backend.packageName,
+                ],
+                doneFn, {
+                  // Disable cgo package. Required to run on scratch docker image.
+                  CGO_ENABLED: '0',
+                  // Scratch docker image is linux.
+                  GOOS: 'linux',
+                });
+          },
+          function(error) { doneFn(error); });
 });

build/build.js

@@ -45,54 +45,53 @@ gulp.task('build', ['backend:prod', 'build-frontend']);
  *  3. CSS and JS assets are suffixed with version hash.
  *  4. Everything is saved in the dist directory.
  */
-gulp.task('build-frontend', ['assets', 'index:prod'], function () {
+gulp.task('build-frontend', ['assets', 'index:prod'], function() {
   let htmlFilter = gulpFilter('*.html', {restore: true});
   let vendorCssFilter = gulpFilter('**/vendor.css', {restore: true});
   let vendorJsFilter = gulpFilter('**/vendor.js', {restore: true});
   let assets;
 
   return gulp.src(path.join(conf.paths.prodTmp, '*.html'))
-    .pipe(assets = gulpUseref.assets({
-      searchPath: [
-        // To resolve local paths.
-        conf.paths.prodTmp,
-        // To resolve bower_components/... paths.
-        conf.paths.base,
-      ],
-    }))
-    .pipe(vendorCssFilter)
-    .pipe(gulpMinifyCss())
-    .pipe(vendorCssFilter.restore)
-    .pipe(vendorJsFilter)
-    .pipe(gulpUglify({preserveComments: uglifySaveLicense}))
-    .pipe(vendorJsFilter.restore)
-    .pipe(gulpRev())
-    .pipe(assets.restore())
-    .pipe(gulpUseref({searchPath: [conf.paths.prodTmp]}))
-    .pipe(gulpRevReplace())
-    .pipe(htmlFilter)
-    .pipe(gulpMinifyHtml({
-      empty: true,
-      spare: true,
-      quotes: true,
-    }))
-    .pipe(htmlFilter.restore)
-    .pipe(gulp.dest(conf.paths.distPublic));
+      .pipe(assets = gulpUseref.assets({
+        searchPath: [
+          // To resolve local paths.
+          conf.paths.prodTmp,
+          // To resolve bower_components/... paths.
+          conf.paths.base,
+        ],
+      }))
+      .pipe(vendorCssFilter)
+      .pipe(gulpMinifyCss())
+      .pipe(vendorCssFilter.restore)
+      .pipe(vendorJsFilter)
+      .pipe(gulpUglify({preserveComments: uglifySaveLicense}))
+      .pipe(vendorJsFilter.restore)
+      .pipe(gulpRev())
+      .pipe(assets.restore())
+      .pipe(gulpUseref({searchPath: [conf.paths.prodTmp]}))
+      .pipe(gulpRevReplace())
+      .pipe(htmlFilter)
+      .pipe(gulpMinifyHtml({
+        empty: true,
+        spare: true,
+        quotes: true,
+      }))
+      .pipe(htmlFilter.restore)
+      .pipe(gulp.dest(conf.paths.distPublic));
 });
 
 
 /**
  * Copies assets to the dist directory.
  */
-gulp.task('assets', function () {
+gulp.task('assets', function() {
   return gulp.src(path.join(conf.paths.assets, '/**/*'), {base: conf.paths.app})
-    .pipe(gulp.dest(conf.paths.distPublic));
+      .pipe(gulp.dest(conf.paths.distPublic));
 });
 
 
 /**
  * Cleans all build artifacts.
  */
-gulp.task('clean', function () {
-  return del([conf.paths.dist, conf.paths.goWorkspace, conf.paths.tmp]);
-});
+gulp.task(
+    'clean', function() { return del([conf.paths.dist, conf.paths.goWorkspace, conf.paths.tmp]); });

build/check.js

@@ -16,6 +16,7 @@
  * @fileoverview Gulp tasks for checking and validating the code or a commit.
  */
 import gulp from 'gulp';
+import gulpClangFormat from 'gulp-clang-format';
 import gulpEslint from 'gulp-eslint';
 import path from 'path';
 
@@ -30,16 +31,45 @@ import conf from './conf';
  **/
 gulp.task('check', ['lint', 'build', 'test', 'integration-test:prod']);
 
+
+/**
+ * Lints all projects code files.
+ * // TODO(bryk): Also lint Go files here.
+ */
+gulp.task('lint', ['lint-javascript', 'check-javascript-format']);
+
+
+/**
+ * Lints all projects JavaScript files using ESLint. This includes frontend source code, as well as,
+ * build scripts.
+ */
+gulp.task('lint-javascript', function() {
+  return gulp.src([path.join(conf.paths.src, '**/*.js'), path.join(conf.paths.build, '**/*.js')])
+      // Attach lint output to the eslint property of the file.
+      .pipe(gulpEslint())
+      // Output the lint results to the console.
+      .pipe(gulpEslint.format())
+      // Exit with an error code (1) on a lint error.
+      .pipe(gulpEslint.failOnError());
+});
+
+
 /**
- * Lints all projects code files. This includes frontend source code, as well as, build scripts.
+ * Checks whether project's JavaScript files are formatted according to clang-format style.
  */
-gulp.task('lint', function() {
-  // TODO(bryk): Also lint Go files here.
+gulp.task('check-javascript-format', function() {
   return gulp.src([path.join(conf.paths.src, '**/*.js'), path.join(conf.paths.build, '**/*.js')])
-    // Attach lint output to the eslint property of the file.
-    .pipe(gulpEslint())
-    // Output the lint results to the console.
-    .pipe(gulpEslint.format())
-    // Exit with an error code (1) on a lint error.
-    .pipe(gulpEslint.failOnError());
+      .pipe(gulpClangFormat.checkFormat('file', undefined, {verbose: true, fail: true}));
+});
+
+
+/**
+ * Formats all project's JavaScript files using clang-format.
+ */
+gulp.task('format-javascript', function() {
+  return gulp.src(
+                 [path.join(conf.paths.src, '**/*.js'), path.join(conf.paths.build, '**/*.js')],
+                 {base: conf.paths.base})
+      .pipe(gulpClangFormat.format('file'))
+      .pipe(gulp.dest(conf.paths.base));
 });