review with Raffo

mloiseleur · mloiseleur · commit 971c91d2cfd2 · 2024-05-16T10:51:13.000+02:00
diff --git a/source/ambassador_host.go b/source/ambassador_host.go
@@ -142,7 +142,7 @@ func (sc *ambassadorHostSource) Endpoints(ctx context.Context) ([]*endpoint.Endp
 			}
 		}
 
-		hostEndpoints, err := sc.endpointsFromHost(ctx, host, targets)
+		hostEndpoints, err := sc.endpointsFromHost(host, targets)
 		if err != nil {
 			log.Warningf("Could not get endpoints for Host %s", err)
 			continue
@@ -164,7 +164,7 @@ func (sc *ambassadorHostSource) Endpoints(ctx context.Context) ([]*endpoint.Endp
 }
 
 // endpointsFromHost extracts the endpoints from a Host object
-func (sc *ambassadorHostSource) endpointsFromHost(_ context.Context, host *ambassador.Host, targets endpoint.Targets) ([]*endpoint.Endpoint, error) {
+func (sc *ambassadorHostSource) endpointsFromHost(host *ambassador.Host, targets endpoint.Targets) ([]*endpoint.Endpoint, error) {
 	var endpoints []*endpoint.Endpoint
 	annotations := host.Annotations
 

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ func (sc ambassadorHostSource) Endpoints(ctx context.Context) ([]endpoint.Endp`
`142`	`142`	`}`
`143`	`143`	`}`
`144`	`144`
`145`		`- hostEndpoints, err := sc.endpointsFromHost(ctx, host, targets)`
	`145`	`+ hostEndpoints, err := sc.endpointsFromHost(host, targets)`
`146`	`146`	`if err != nil {`
`147`	`147`	`log.Warningf("Could not get endpoints for Host %s", err)`
`148`	`148`	`continue`
`@@ -164,7 +164,7 @@ func (sc ambassadorHostSource) Endpoints(ctx context.Context) ([]endpoint.Endp`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`// endpointsFromHost extracts the endpoints from a Host object`
`167`		`-func (sc ambassadorHostSource) endpointsFromHost(_ context.Context, host ambassador.Host, targets endpoint.Targets) ([]*endpoint.Endpoint, error) {`
	`167`	`+func (sc ambassadorHostSource) endpointsFromHost(host ambassador.Host, targets endpoint.Targets) ([]*endpoint.Endpoint, error) {`
`168`	`168`	`var endpoints []*endpoint.Endpoint`
`169`	`169`	`annotations := host.Annotations`
`170`	`170`