object doesn't get updated after fakeClient.Delete(object)

[Nihileon]

fakeClient.Delete(obj) doesn't update deletionTimestamp of the obj passed to the function. The bug is in fakeClient.deleteObject, since it gets a new object and updates the new object without rewriting the original object.

Reference: https://github.com/kubernetes-sigs/controller-runtime/blob/v0.19.0/pkg/client/fake/client.go#L1085-L1095

[sbueringer]

I assume the regular client updates it? (I think I remember that the regular client also doesn't update it, but I'm not sure)

[alvaroaleman]

Actually it looks like it doesn't:

controller-runtime/pkg/client/typed_client.go

Line 86 in 8e44a43

Body(deleteOpts.AsDeleteOptions()).

So after someone deletes an object, their in-mem representation doesn't reflect that? That is different from all other methods and very confusing

[sbueringer]

Yeah. I think I noticed this 1-2 months ago in a unit test. First I thought the fake client is the problem but then I saw that the real client has the same behavior :)

[troy0820]

I can take this one if you all don't mind.

/assign @troy0820

[sbueringer]

I'm wondering if there are comparable cases in client-go and how they are handled there

[troy0820]

/unassign @troy0820

I unfortunately do not have the time to commit to work through the PR for this. I am going to unassign myself for anyone who wants to take this.

[troy0820]

Yeah. I think I noticed this 1-2 months ago in a unit test. First I thought the fake client is the problem but then I saw that the real client has the same behavior :)

Do we want to change the real client behavior and then map that to the fakeClient?

[sbueringer]

I'm wondering if there are comparable cases in client-go and how they are handled there

I think knowing ^^ would be good to inform our decision.

Do we get the object with deletionTimestamp back when we do the actual delete call?

[troy0820]

I'm wondering if there are comparable cases in client-go and how they are handled there

I think knowing ^^ would be good to inform our decision.

Do we get the object with deletionTimestamp back when we do the actual delete call?

I don't think we do unless I am reading this wrong on the dynamic client which uses the rest.Interface.

https://github.com/kubernetes/client-go/blob/f2030849e1d6d961fa150b9be9560da33e5d00df/dynamic/simple.go#L205-L219

func (c *dynamicResourceClient) Delete(ctx context.Context, name string, opts metav1.DeleteOptions, subresources ...string) error {
	if len(name) == 0 {
		return fmt.Errorf("name is required")
	}
	if err := validateNamespaceWithOptionalName(c.namespace, name); err != nil {
		return err
	}

	result := c.client.client.
		Delete().
		AbsPath(append(c.makeURLSegments(name), subresources...)...).
		Body(&opts).
		Do(ctx)
	return result.Error()
}

[sbueringer]

Looks like it. Not sure if there either simply is nothing in the response body or if we just don't read it