-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Open
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.
Description
Tasks
- v0.20.0
- v0.21.0
- 🌱 Add priority label to PQ depth metric #3156
- 🐛Fix behavior of rate limit option in priorityqueue.AddWithOpts #3103
- 🌱 Add debug logging for the state of the priority queue #3075
- ✨ Leverage isInInitialList of ResourceEventHandler.OnAdd, Add IsInInitialList to TypedCreateEvent #3162
- 🌱 Remove redundant WithLowPriorityWhenUnchanged in builder #3168
- ✨ Controller: Retain the priority #3167
- 🐛Implement priorityqueue as default on handlers if using priorityqueue interface #3111
- 🌱 Handlers: Use low priority when object is unchanged and priority queue #3152
- 🌱 Followups to default low priority in mappers #3160
- 🌱 TypedEnqueueRequestForOwner: Decrease priority when unchanged #3174
- v0.22.0
- v0.23 (upcoming)
Ideas:
- Add Priority parameter to reconcile.Request (xref: 📖 Add a design for a priority queue #3013 (comment))
- Won't implement until we have a clear use case for it
Feature enablement
The feature can be enabled by setting the UsePriorityQueue
option to true, e.g.:
ctrlOptions := ctrl.Options{
Controller: config.Controller{
UsePriorityQueue: ptr.To[bool](true),
},
...
}
mgr, err := ctrl.NewManager(restConfig, ctrlOptions)
Original issue description
While discussing #857 (comment) an idea come up about having something like a priority queue, so we can give resync events a lower priority while assigning to other events a higher priority.
This could help when there are many objects of the same type and at every resync period there is a storm of events being added to the queue.
sbueringer, rabbitfang, cbuto, nao99, ebensom and 4 morealvaroaleman, nathanperkins, tsuzu and merusso
Metadata
Metadata
Assignees
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.