Skip to content

Commit 0ee2548

Browse files
committed
review fixes
1 parent daaaa19 commit 0ee2548

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

scripts/ci-e2e-lib.sh

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,19 @@ k8s::prepareKindestImagesVariables() {
5757
KUBERNETES_VERSION=$(grep KUBERNETES_VERSION: < "$E2E_CONF_FILE" | awk -F'"' '{ print $2}')
5858
echo "Defaulting KUBERNETES_VERSION to ${KUBERNETES_VERSION} to trigger image build (because env var is not set)"
5959
fi
60+
fi
6061

61-
# Tests not focusing on [PR-Blocking] or [K8s-Install], also run upgrade tests so default
62-
# KUBERNETES_VERSION_UPGRADE_TO to the value in the e2e config if it is not set.
63-
if [[ ${GINKGO_FOCUS:-} != *"PR-Blocking"* ]] && [[ ${GINKGO_FOCUS:-} != *"K8s-Install"* ]]; then
64-
if [[ -z "${KUBERNETES_VERSION_UPGRADE_TO:-}" ]]; then
65-
KUBERNETES_VERSION_UPGRADE_TO=$(grep KUBERNETES_VERSION_UPGRADE_TO: < "$E2E_CONF_FILE" | awk -F'"' '{ print $2}')
66-
echo "Defaulting KUBERNETES_VERSION_UPGRADE_TO to ${KUBERNETES_VERSION_UPGRADE_TO} to trigger image build (because env var is not set)"
67-
fi
62+
# Tests not focusing on [PR-Blocking], [K8s-Install] or [K8s-Install-ci-latest],
63+
# also run upgrade tests so default KUBERNETES_VERSION_UPGRADE_TO to the value
64+
# in the e2e config if it is not set.
65+
if [[ ${GINKGO_FOCUS:-} != *"PR-Blocking"* ]] && [[ ${GINKGO_FOCUS:-} != *"K8s-Install"* ]]; then
66+
if [[ -z "${KUBERNETES_VERSION_UPGRADE_TO:-}" ]]; then
67+
KUBERNETES_VERSION_UPGRADE_TO=$(grep KUBERNETES_VERSION_UPGRADE_TO: < "$E2E_CONF_FILE" | awk -F'"' '{ print $2}')
68+
echo "Defaulting KUBERNETES_VERSION_UPGRADE_TO to ${KUBERNETES_VERSION_UPGRADE_TO} to trigger image build (because env var is not set)"
69+
fi
70+
if [[ -z "${KUBERNETES_VERSION_UPGRADE_FROM:-}" ]]; then
71+
KUBERNETES_VERSION_UPGRADE_FROM=$(grep KUBERNETES_VERSION_UPGRADE_FROM: < "$E2E_CONF_FILE" | awk -F'"' '{ print $2}')
72+
echo "Defaulting KUBERNETES_VERSION_UPGRADE_FROM to ${KUBERNETES_VERSION_UPGRADE_FROM} to trigger image build (because env var is not set)"
6873
fi
6974
fi
7075
}

0 commit comments

Comments
 (0)