|
1 |
| -<!-- |
2 |
| -Thanks for sending a Pull Request (PR)! Please use this template to facilitate the review/merge process. |
3 |
| -
|
4 |
| -WARNING!!! Make sure that the PR fullfills the review criteria before submitting: |
5 |
| -
|
6 |
| -POSITIVES |
7 |
| -- Change has already been discussed and is known to committers (open an issue first otherwise) |
8 |
| -- Has a nice, self-explanatory title |
9 |
| -- Fixes the root cause of a bug in existing functionality |
10 |
| -- Adds functionality or fixes a problem needed by a large number of users |
11 |
| -- Simple, targeted |
12 |
| -- Easily tested; has tests |
13 |
| -- Reduces complexity and lines of code |
14 |
| -
|
15 |
| -NEGATIVES |
16 |
| -- Makes lots of modifications in one "big bang" change |
17 |
| -- Band-aids a symptom of a bug only |
18 |
| -- Introduces complex new functionality |
19 |
| -- Adds complexity that only helps a niche use case |
20 |
| -- Adds user-space functionality that does not need to be maintained in KubeNow, but could be hosted externally |
21 |
| -- Adds large dependencies |
22 |
| -- Changes versions of existing dependencies |
23 |
| -- Adds a large amount of code |
24 |
| ---> |
25 |
| - |
26 | 1 | ## Change content and motivation
|
27 | 2 | <!-- please describe briefly the content of this PR, and motivate why this changes are needed -->
|
28 | 3 |
|
29 |
| -## GitHub cross-links |
| 4 | +<!-- Please uncomment if applicable --> |
| 5 | +<!-- ## GitHub cross-links --> |
30 | 6 | <!--
|
31 | 7 | please list the issues that are going to be fixed by this PR (if applicable).
|
32 | 8 | Use the suggested format to facilitate issue closing.
|
33 | 9 | -->
|
34 |
| -**Fixes:** <!-- fixes #X, fixes #Y, ... fixes #Z --> |
| 10 | +<!-- Fixes #X, fixes #Y, ... fixes #Z --> |
35 | 11 | <!--
|
36 | 12 | please add documentation for your feature (if applicable), and link the documentation changes.
|
37 | 13 | Documentation PRs are to be sent to https://github.com/kubenow/docs.
|
38 | 14 | -->
|
39 |
| -**Docs**: <!-- #X, #Y, ... #Z --> |
| 15 | +<!-- Docs: kubenow/docs#X, kubenow/docs#Y, ... kubenow/docs#Z --> |
0 commit comments