Skip to content

Conversation

@13241308289
Copy link
Contributor

@13241308289 13241308289 commented Mar 4, 2024

…ach job and add metric: kubedl_job_finished_time

Ⅰ. Describe what this PR does

1、Refactor kubedl_job_status implementation to log status changes for each job
2、Add metric: kubedl_job_finished_time

II. Does this pull request fix one issue?

fixes #309

III. Special notes for reviewers if any.

@codecov
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 30.88%. Comparing base (b93a2b4) to head (6a175de).

Files Patch % Lines
pkg/metrics/job_metrics.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
- Coverage   30.92%   30.88%   -0.04%     
==========================================
  Files         108      108              
  Lines        7024     7033       +9     
==========================================
  Hits         2172     2172              
- Misses       4556     4565       +9     
  Partials      296      296              
Flag Coverage Δ
unittests 30.88% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ach job and add metric: kubedl_job_finished_time

Signed-off-by: paradox <[email protected]>
Signed-off-by: paradox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant