Skip to content

Commit 80d43fd

Browse files
authored
Documentation cleanup around Api core_methods and dynamic_watcher (#1158)
* Minor fixes to metadata watcher examples - makes dyn watcher runnable without clux.dev crds Signed-off-by: clux <[email protected]> * Fixup core_methods Api docs to use async_wrapper Also add better examples to metadata api and using new conversion. Signed-off-by: clux <[email protected]> * ping hooks - 2023-03-03 Signed-off-by: clux <[email protected]> --------- Signed-off-by: clux <[email protected]>
1 parent edb7aae commit 80d43fd

File tree

4 files changed

+232
-207
lines changed

4 files changed

+232
-207
lines changed

examples/dynamic_watcher.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ async fn main() -> anyhow::Result<()> {
1717
let watch_metadata = env::var("WATCH_METADATA").map(|s| s == "1").unwrap_or(false);
1818

1919
// Take dynamic resource identifiers:
20-
let group = env::var("GROUP").unwrap_or_else(|_| "clux.dev".into());
20+
let group = env::var("GROUP").unwrap_or_else(|_| "".into());
2121
let version = env::var("VERSION").unwrap_or_else(|_| "v1".into());
22-
let kind = env::var("KIND").unwrap_or_else(|_| "Foo".into());
22+
let kind = env::var("KIND").unwrap_or_else(|_| "Pod".into());
2323

2424
// Turn them into a GVK
2525
let gvk = GroupVersionKind::gvk(&group, &version, &kind);

0 commit comments

Comments
 (0)