Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make buffer volume metrics PrometheusRules configurable #1928

Open
sebastiangaiser opened this issue Jan 27, 2025 · 1 comment
Open

Make buffer volume metrics PrometheusRules configurable #1928

sebastiangaiser opened this issue Jan 27, 2025 · 1 comment
Milestone

Comments

@sebastiangaiser
Copy link
Contributor

sebastiangaiser commented Jan 27, 2025

Is your feature request related to a problem? Please describe.
In #1790 PrometheusRule overrides were introduced. Unfortunately only for FluentD/Fluent-bit metrics and not for buffer volume metrics.

Describe the solution you'd like
Please add the same overrides for the buffer volume metrics, e.g.:

fluentd:
  bufferVolumeMetrics:
    prometheusRules: true
    prometheusRulesOverride:
    - alert: FluentbitBufferSize
      labels:
         severity:  warning # former 'critical'
fluentd:
  bufferVolumeMetrics:
    prometheusRules: true
    prometheusRulesOverride:
    - alert: FluentdPredictedBufferGrowth
      expr: ...
syslogng:
  bufferVolumeMetrics:
    prometheusRules: true
    prometheusRulesOverride:
    ...

Describe alternatives you've considered
Disable prometheusRules and deploy them separately.

Additional context

@sebastiangaiser
Copy link
Contributor Author

This may also solve #1923

@pepov pepov added this to the 5.x milestone Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants