Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay offsets if there is a skip at the beginning of the map #41

Open
OlegSuperBro opened this issue May 19, 2023 · 2 comments
Open

Replay offsets if there is a skip at the beginning of the map #41

OlegSuperBro opened this issue May 19, 2023 · 2 comments

Comments

@OlegSuperBro
Copy link

OlegSuperBro commented May 19, 2023

When trying read and write replay with skip at beginning, it offsets. I used this code:

from osrparse import Replay
replay = Replay.from_path("replay_file.osr")
replay.write_path("out.osr")

replay_file.osr works as intended, but out.osr gets offset

@tybug
Copy link
Collaborator

tybug commented May 20, 2023

This is a result of the v7.0.0 release.

I hadn't considered that users would expect written replays to preserve the initial break frames. I think @kszlim was right in suggesting we add a parameter to preserve these frames - it's a bit of a sticky situation all around, but the parameter is likely the best solution.

@OlegSuperBro
Copy link
Author

OlegSuperBro commented May 20, 2023

I tried again and now it works fine, I did nothing
Edit: Nevermind, it breaks after changing something in replay, but after trying to export the replay even without changes, it breaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants