Skip to content

Commit aecee27

Browse files
authored
Use the REST_PROXY_SKIP_VERIFY env var for TLS setup (#48)
[RHOAIENG-14237](https://issues.redhat.com/browse/RHOAIENG-14237) Depends on kserve/modelmesh-serving#536 Signed-off-by: Hannah DeFazio <[email protected]>
1 parent 79c27d9 commit aecee27

File tree

1 file changed

+20
-7
lines changed

1 file changed

+20
-7
lines changed

proxy/main.go

+20-7
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,13 @@ import (
3434
)
3535

3636
const (
37-
restProxyPortEnvVar = "REST_PROXY_LISTEN_PORT"
38-
restProxyGrpcMaxMsgSize = "REST_PROXY_GRPC_MAX_MSG_SIZE_BYTES"
39-
restProxyGrpcPortEnvVar = "REST_PROXY_GRPC_PORT"
40-
restProxyTlsEnvVar = "REST_PROXY_USE_TLS"
41-
tlsCertEnvVar = "MM_TLS_KEY_CERT_PATH"
42-
tlsKeyEnvVar = "MM_TLS_PRIVATE_KEY_PATH"
37+
restProxyPortEnvVar = "REST_PROXY_LISTEN_PORT"
38+
restProxyGrpcMaxMsgSize = "REST_PROXY_GRPC_MAX_MSG_SIZE_BYTES"
39+
restProxyGrpcPortEnvVar = "REST_PROXY_GRPC_PORT"
40+
restProxyTlsEnvVar = "REST_PROXY_USE_TLS"
41+
restProxySkipVerifyEnvVar = "REST_PROXY_SKIP_VERIFY"
42+
tlsCertEnvVar = "MM_TLS_KEY_CERT_PATH"
43+
tlsKeyEnvVar = "MM_TLS_PRIVATE_KEY_PATH"
4344
)
4445

4546
var (
@@ -85,8 +86,20 @@ func run() error {
8586
var transportCreds credentials.TransportCredentials
8687
if useTLS, ok := os.LookupEnv(restProxyTlsEnvVar); ok && useTLS == "true" {
8788
logger.Info("Using TLS")
89+
90+
skipVerifyBool := false
91+
skipVerify, ok := os.LookupEnv(restProxySkipVerifyEnvVar)
92+
if ok {
93+
err := *new(error)
94+
skipVerifyBool, err = strconv.ParseBool(skipVerify)
95+
if err != nil {
96+
logger.Error(err, "Failed to parse %s=%s to bool", restProxySkipVerifyEnvVar, skipVerify)
97+
skipVerifyBool = false
98+
}
99+
}
100+
88101
transportCreds = credentials.NewTLS(&tls.Config{
89-
InsecureSkipVerify: true,
102+
InsecureSkipVerify: skipVerifyBool,
90103
})
91104
} else {
92105
logger.Info("Not using TLS")

0 commit comments

Comments
 (0)