Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pytests failing #334

Closed
ChristopherMancuso opened this issue Nov 14, 2024 · 5 comments
Closed

fix pytests failing #334

ChristopherMancuso opened this issue Nov 14, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@ChristopherMancuso
Copy link
Contributor

Right now I have some tests commented out. The ones that used the model weights or the predictions are failing as I think there are some differences in the model training, especially for low probability genes across species. Might need a different pytest input and results.

@ChristopherMancuso ChristopherMancuso self-assigned this Nov 14, 2024
@ChristopherMancuso ChristopherMancuso added the bug Something isn't working label Nov 14, 2024
@ChristopherMancuso
Copy link
Contributor Author

These include

  • model probs
  • model similarities
  • genes in the edgelist

@ChristopherMancuso
Copy link
Contributor Author

another thing is that @falquaddoomi mentioned is that the way were are running the tests might be redundant, i.e. we have tests set up fro multiple python versions and OSs in GitHub actions, but then possibly also doing that in our tox configuration. Cutting down on too many tests will help with the tests taking so long to run.

@ChristopherMancuso
Copy link
Contributor Author

Also, try to figure out a way to just get all the pytest data into cache, I think each test is downloading from Zenodo. If there is a pytest for downloading, probably best to remove that.

@ChristopherMancuso
Copy link
Contributor Author

seems like removing the scaling in code and PreTrainedWeights makes the tests act like they should

@ChristopherMancuso
Copy link
Contributor Author

I feel like #364 fixed the main reason the tests failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant