Skip to content

Commit 1685b30

Browse files
authored
Revert "Revert ":sparkles: Support task addon succeeded with errors."" (#706)
Reverts #690
1 parent 0943166 commit 1685b30

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

addon/task.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ func (h *Task) Succeeded() {
115115
// Failed report addon failed.
116116
// The reason can be a printf style format.
117117
func (h *Task) Failed(reason string, v ...any) {
118+
h.report.Status = task.Failed
118119
reason = fmt.Sprintf(reason, v...)
119120
h.Error(api.TaskError{
120121
Severity: "Error",
@@ -137,7 +138,6 @@ func (h *Task) Errorf(severity, description string, v ...any) {
137138

138139
// Error report addon error.
139140
func (h *Task) Error(error ...api.TaskError) {
140-
h.report.Status = task.Failed
141141
for i := range error {
142142
h.report.Errors = append(
143143
h.report.Errors,

0 commit comments

Comments
 (0)