Fixed setMeta() wouldn't remove meta from database when setting a default value defined in defaultMetaValues property

Author: siamak2

src/Kodeine/Metable/Metable.php

@@ -45,6 +45,19 @@ public function setMeta($key, $value = null) {
 
 	protected function setMetaString($key, $value) {
 		$key = strtolower( $key );
+		
+		// If there is a default value, remove the meta row instead - future returns of
+		// this value will be handled via the default logic in the accessor
+		if (
+			property_exists( $this, 'defaultMetaValues' ) &&
+			array_key_exists( $key, $this->defaultMetaValues ) &&
+			$this->defaultMetaValues[$key] == $value
+		) {
+			$this->unsetMeta( $key );
+			
+			return $this;
+		}
+		
 		if ( $this->getMetaData()->has( $key ) ) {
 
 			// Make sure deletion marker is not set

tests/MetableTest.php

@@ -176,6 +176,16 @@ public function testDefaultMetaValues() {
 
 		$this->assertNull( $metaData->first(), 'Default value should be removed from database.' );
 
+		$user->setMeta( 'default_meta_key', 'foo' );
+		$user->save();
+		
+		$this->assertEquals( 'foo', is_null( $meta = $metaData->first() ) ? null : $meta->value, 'Default value should be changed in database.' );
+		
+		$user->setMeta( 'default_meta_key', 'default_meta_value' );
+		$user->save();
+		
+		$this->assertNull( $metaData->first(), 'Default value should be removed from database.' );
+		
 		$user->delete();
 	}