Skip to content

Commit 739e719

Browse files
committed
Spinner: Update markup for buttons
1 parent eae5671 commit 739e719

File tree

1 file changed

+13
-14
lines changed

1 file changed

+13
-14
lines changed

ui/widgets/spinner.js

+13-14
Original file line numberDiff line numberDiff line change
@@ -230,12 +230,8 @@ $.widget( "ui.spinner", {
230230

231231
// Add buttons
232232
.append(
233-
"<a>" +
234-
"<span>&#9650;</span>" +
235-
"</a>" +
236-
"<a>" +
237-
"<span>&#9660;</span>" +
238-
"</a>"
233+
"<a></a>" +
234+
"<a></a>"
239235
);
240236
},
241237

@@ -250,6 +246,7 @@ $.widget( "ui.spinner", {
250246
// Button bindings
251247
this.buttons = this.uiSpinner.children( "a" )
252248
.attr( "tabIndex", -1 )
249+
.attr( "aria-hidden", true )
253250
.button( {
254251
classes: {
255252
"ui-button": ""
@@ -261,8 +258,14 @@ $.widget( "ui.spinner", {
261258

262259
this._addClass( this.buttons.first(), "ui-spinner-button ui-spinner-up" );
263260
this._addClass( this.buttons.last(), "ui-spinner-button ui-spinner-down" );
264-
this.buttons.first().button( "option", "icon", this.options.icons.up );
265-
this.buttons.last().button( "option", "icon", this.options.icons.down );
261+
this.buttons.first().button( {
262+
"icon": this.options.icons.up,
263+
"showLabel": false
264+
} );
265+
this.buttons.last().button({
266+
"icon": this.options.icons.down,
267+
"showLabel": false
268+
} );
266269

267270
// IE 6 doesn't understand height: 50% for the buttons
268271
// unless the wrapper has an explicit height
@@ -562,12 +565,8 @@ if ( $.uiBackCompat !== false ) {
562565

563566
_buttonHtml: function() {
564567
return "" +
565-
"<a>" +
566-
"<span>&#9650;</span>" +
567-
"</a>" +
568-
"<a>" +
569-
"<span>&#9660;</span>" +
570-
"</a>";
568+
"<a></a>" +
569+
"<a></a>";
571570
}
572571
} );
573572
}

0 commit comments

Comments
 (0)