chore: Fix regression in determining tag for conventional commits (#1133)

Co-authored-by: Dylan Anthony <[email protected]>

Author: dbanty

Diff for: crates/knope/src/integrations/git.rs

@@ -142,16 +142,6 @@ enum ErrorKind {
         help("A Git tag could not be created for the release.")
     )]
     CreateTagError(#[from] gix::tag::Error),
-    #[error("Could not find reference {reference}: {source}")]
-    #[diagnostic(
-        code(releases::git::find_reference),
-        help("Please check that the reference exists.")
-    )]
-    FindReference {
-        reference: String,
-        #[source]
-        source: gix::reference::find::existing::Error,
-    },
     #[error("Could not peel oid: {0}")]
     #[diagnostic(
         code(releases::git::peel_oid),
@@ -395,24 +385,16 @@ pub(crate) fn add_files(file_names: &[RelativePathBuf]) -> Result<(), Error> {
 /// means that there could be paths which jump _behind_ the target tag... and we want to exclude
 /// those as well. There's probably a way to optimize performance with some cool graph magic
 /// eventually, but this is good enough for now.
-pub(crate) fn get_commit_messages_after_tag(tag: Option<&str>) -> Result<Vec<String>, Error> {
+pub(crate) fn get_commit_messages_after_tag(tag: &str) -> Result<Vec<String>, Error> {
     let repo = gix::open(".")?;
-    if let Some(tag) = &tag {
-        debug!("Finding all commits since tag {tag}");
+
+    let reference = repo.find_reference(&format!("refs/tags/{tag}")).ok();
+    if reference.is_some() {
+        debug!("Using commits since tag {tag}");
     } else {
-        debug!("Finding ALL commits");
+        debug!("Tag {tag} not found, using ALL commits");
     }
-    let commits_to_exclude = tag
-        .map(|tag| format!("refs/tags/{tag}"))
-        .as_ref()
-        .map(|reference| {
-            repo.find_reference(reference)
-                .map_err(|err| ErrorKind::FindReference {
-                    reference: reference.clone(),
-                    source: err,
-                })
-        })
-        .transpose()?
+    let commits_to_exclude = reference
         .map(gix::Reference::into_fully_peeled_id)
         .transpose()?
         .and_then(|tag_oid| repo.find_object(tag_oid).ok().map(gix::Object::into_commit))

Diff for: crates/knope/src/step/releases/conventional_commits.rs

@@ -1,8 +1,4 @@
-use knope_versioning::{
-    package,
-    semver::{PackageVersions, StableVersion},
-    ReleaseTag,
-};
+use knope_versioning::{package, semver::PackageVersions, ReleaseTag};
 use tracing::debug;
 
 use crate::integrations::git::{self, get_commit_messages_after_tag};
@@ -20,11 +16,7 @@ pub(crate) fn get_conventional_commits_after_last_stable_version(
         debug!("Only checking commits with scopes: {scopes:?}");
     }
     let target_version = PackageVersions::from_tags(package_name.as_custom(), all_tags).stable();
-    let tag = if target_version == StableVersion::default() {
-        None
-    } else {
-        Some(ReleaseTag::new(&target_version.into(), package_name))
-    };
+    let tag = ReleaseTag::new(&target_version.into(), package_name);
 
-    get_commit_messages_after_tag(tag.as_ref().map(ReleaseTag::as_str)).map_err(git::Error::from)
+    get_commit_messages_after_tag(tag.as_str()).map_err(git::Error::from)
 }

Diff for: crates/knope/tests/prepare_release/go_modules/major_version_directories/dryrun_stdout.log

@@ -11,7 +11,7 @@ No tags found matching pattern v2/v
 Getting conventional commits since last release of package v1
 Only checking commits with scopes: ["v1"]
 No tags found matching pattern v1/v
-Finding ALL commits
+Tag v1/v0.0.0 not found, using ALL commits
 Determining new version for v1
 commit fix(v1): A fix
 	implies rule PATCH
@@ -32,7 +32,7 @@ Would add files to git:
 Getting conventional commits since last release of package v2
 Only checking commits with scopes: ["v2"]
 No tags found matching pattern v2/v
-Finding ALL commits
+Tag v2/v0.0.0 not found, using ALL commits
 Determining new version for v2
 commit feat(v2): New feature
 	implies rule MINOR

Diff for: crates/knope/tests/prepare_release/go_modules/major_version_directories/stdout.log

@@ -11,15 +11,15 @@ No tags found matching pattern v2/v
 Getting conventional commits since last release of package v1
 Only checking commits with scopes: ["v1"]
 No tags found matching pattern v1/v
-Finding ALL commits
+Tag v1/v0.0.0 not found, using ALL commits
 Determining new version for v1
 commit fix(v1): A fix
 	implies rule PATCH
 Using PATCH rule to bump from 1.0.0 to 1.0.1
 Getting conventional commits since last release of package v2
 Only checking commits with scopes: ["v2"]
 No tags found matching pattern v2/v
-Finding ALL commits
+Tag v2/v0.0.0 not found, using ALL commits
 Determining new version for v2
 commit feat(v2): New feature
 	implies rule MINOR

Diff for: crates/knope/tests/prepare_release/verbose/dryrun_stdout.log

@@ -7,7 +7,7 @@ package.json has version 0.4.6
 Looking for Git tags matching package name.
 Getting conventional commits since last release of package first
 Only checking commits with scopes: ["first"]
-Finding all commits since tag first/v1.2.3
+Using commits since tag first/v1.2.3
 Determining new version for first
 commit feat: A feature
 	implies rule MINOR
@@ -72,7 +72,7 @@ Would add files to git:
   FIRST_CHANGELOG.md
 Getting conventional commits since last release of package second
 Only checking commits with scopes: ["second"]
-Finding all commits since tag second/v0.4.6
+Using commits since tag second/v0.4.6
 Determining new version for second
 commit feat: A feature
 	implies rule MINOR

Diff for: crates/knope/tests/prepare_release/verbose/stdout.log

@@ -7,7 +7,7 @@ package.json has version 0.4.6
 Looking for Git tags matching package name.
 Getting conventional commits since last release of package first
 Only checking commits with scopes: ["first"]
-Finding all commits since tag first/v1.2.3
+Using commits since tag first/v1.2.3
 Determining new version for first
 commit feat: A feature
 	implies rule MINOR
@@ -34,7 +34,7 @@ changeset feature.md
 Using MAJOR rule to bump from 1.2.3 to 2.0.0
 Getting conventional commits since last release of package second
 Only checking commits with scopes: ["second"]
-Finding all commits since tag second/v0.4.6
+Using commits since tag second/v0.4.6
 Determining new version for second
 commit feat: A feature
 	implies rule MINOR