Define handler in terms of CloudEvents rather than http/payload #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should simplify the unit tests. Only the invalid_event test uses the actix-web test helpers, just as an example to show it's the HTTP plumbing that will fail the request when it tries to construct an Event from invalid (or missing) headers.
jcrossley3
requested review from
lance,
lkingland,
matejvasek and
zroubalik
as code owners
lance
approved these changes
Jul 9, 2021
Contributor
lance
left a comment
lance
left a comment
There was a problem hiding this comment.
As a Rust naif, I'll have to trust that this is correct and idiomatic - as I'm sure it is. This looks much nicer anyway.
pub async fn handle(event: Event) -> Result<Event, actix_web::Error> {
zroubalik
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the handler and its tests by using the latest release of the cloudevents-sdk, since they can be written in terms of Events rather than all the HTTP plumbing abstractions.