Skip to content

Commit 2c4a1ff

Browse files
smehboubcodablock
andauthored
fix(deploy): clusterrole manager role (#152)
* fix(deploy): clusterrole manager role * fix: Fix RBAC via kubebuilder comments --------- Co-authored-by: Alexander Block <[email protected]>
1 parent 466091c commit 2c4a1ff

File tree

5 files changed

+5
-2
lines changed

5 files changed

+5
-2
lines changed

config/rbac/role.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ rules:
88
- ""
99
resources:
1010
- configmaps
11+
- namespaces
1112
verbs:
1213
- get
1314
- list

controllers/comments/githubcomment_controller.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ type GithubCommentReconciler struct {
3838
//+kubebuilder:rbac:groups=templates.kluctl.io,resources=githubcomments,verbs=get;list;watch;create;update;patch;delete
3939
//+kubebuilder:rbac:groups=templates.kluctl.io,resources=githubcomments/status,verbs=get;update;patch
4040
//+kubebuilder:rbac:groups=templates.kluctl.io,resources=githubcomments/finalizers,verbs=update
41-
//+kubebuilder:rbac:groups="",resources=configmaps,verbs=get;list;watch
41+
//+kubebuilder:rbac:groups="",resources=configmaps;namespaces,verbs=get;list;watch
4242

4343
func (r *GithubCommentReconciler) Reconcile(ctx context.Context, req ctrl.Request) (result ctrl.Result, err error) {
4444
logger := log.FromContext(ctx)

controllers/comments/gitlabcomment_controller.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ type GitlabCommentReconciler struct {
3838
//+kubebuilder:rbac:groups=templates.kluctl.io,resources=gitlabcomments,verbs=get;list;watch;create;update;patch;delete
3939
//+kubebuilder:rbac:groups=templates.kluctl.io,resources=gitlabcomments/status,verbs=get;update;patch
4040
//+kubebuilder:rbac:groups=templates.kluctl.io,resources=gitlabcomments/finalizers,verbs=update
41-
//+kubebuilder:rbac:groups="",resources=configmaps,verbs=get;list;watch
41+
//+kubebuilder:rbac:groups="",resources=configmaps;namespaces,verbs=get;list;watch
4242

4343
func (r *GitlabCommentReconciler) Reconcile(ctx context.Context, req ctrl.Request) (result ctrl.Result, err error) {
4444
logger := log.FromContext(ctx)

deploy/charts/template-controller/templates/rbac/ClusterRole-manager-role.yml

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ rules:
99
- ""
1010
resources:
1111
- configmaps
12+
- namespaces
1213
verbs:
1314
- get
1415
- list

deploy/manifests/template-controller.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -1714,6 +1714,7 @@ rules:
17141714
- ""
17151715
resources:
17161716
- configmaps
1717+
- namespaces
17171718
verbs:
17181719
- get
17191720
- list

0 commit comments

Comments
 (0)