Skip to content

Commit f3255fb

Browse files
committed
Add TODO comments for Rust codegen options
1 parent 9a71ee7 commit f3255fb

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

build.sh

+4
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,8 @@ done
118118
#export LDFLAGS+=" --source-map-base http://localhost:3000/lib/"
119119

120120
# Rust flags
121+
# TODO(kleisauke): Remove +bulk-memory,+nontrapping-fptoint once Rust updates LLVM to 20, see:
122+
# https://github.com/llvm/llvm-project/commit/1bc2cd98c58a1059170dc38697c7a29a8e21160b
121123
export RUSTFLAGS="-Ctarget-feature=+atomics,+bulk-memory,+nontrapping-fptoint -Zdefault-visibility=hidden"
122124

123125
# Common compiler flags
@@ -132,6 +134,8 @@ if [ "$WASM_EH" = "true" ]; then
132134
export RUSTFLAGS+=" -Zemscripten-wasm-eh"
133135
if [ "$WASM_EXNREF" = "true" ]; then
134136
COMMON_FLAGS+=" -sWASM_LEGACY_EXCEPTIONS=0"
137+
# TODO(kleisauke): Switch to -wasm-use-legacy-eh=0 once Rust updates LLVM to 20, see:
138+
# https://github.com/llvm/llvm-project/commit/a8e1135baa9074f7c088c8e1999561f88699b56e
135139
export RUSTFLAGS+=" -Cllvm-args=-wasm-enable-exnref"
136140
fi
137141
else

0 commit comments

Comments
 (0)