Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded base URL in Emails should be removed #164

Closed
Erikmitk opened this issue Feb 26, 2020 · 2 comments
Closed

Hardcoded base URL in Emails should be removed #164

Erikmitk opened this issue Feb 26, 2020 · 2 comments
Assignees
@claussni

Comments

@Erikmitk
Copy link
Member

Erikmitk commented Feb 26, 2020 •
edited
Loading

kitodo-publication/Classes/Services/Email/Notifier.php

Line 66 in 3749807

$args['###URL###'] = 'http://nbn-resolving.de/' . $mods->getQucosaUrn();

kitodo-publication/Classes/Services/Email/Notifier.php

Line 144 in 3749807

$args['###URL###'] = 'http://nbn-resolving.de/' . $mods->getQucosaUrn();

kitodo-publication/Classes/Plugins/RelatedListTool/RelatedListTool.php

Line 92 in 50ae565

'parameter' => 'http://nbn-resolving.de/' . $value['docId'],

@claussni
Copy link
Member

This URL does not need to be generated. It's there for historical reasons. Better to use the marker ###URN### and generate a proper HTML Link.

@claussni claussni changed the title Hardcoded base URL in Emails should be changed to https Hardcoded base URL in Emails should be removed Feb 26, 2020
@Erikmitk
Copy link
Member Author

Yes, but the RelatedListTool-plugin only need the additional s. That has nothing to do with the Emails.

@claussni claussni mentioned this issue Mar 9, 2020
Merged
claussni added a commit that referenced this issue Mar 11, 2020
@claussni
Merge pull request #165 from kitodo/CMR-955
4c79830 
Use `https` for DNB URN Resolver

Resolves #164
Resolves https://jira.slub-dresden.de/browse/CMR-955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claussni claussni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Erikmitk @claussni