Skip to content

Commit 16030bf

Browse files
committed
test: Update translate.ex cases
1 parent 1de3bbd commit 16030bf

File tree

2 files changed

+9
-16
lines changed

2 files changed

+9
-16
lines changed

elixir-api/test/api/post_posts_test.exs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,12 +220,10 @@ defmodule PostPostsTest do
220220
total: length(stub_posts["result"])
221221
)
222222

223-
stub_posts_translatable_calls = length(stub_posts["result"])
224-
225223
Hexerei.HTTP.MockClient
226224
|> Mox.expect(
227225
:get,
228-
2,
226+
length(stub_posts["result"]),
229227
fn url, _headers ->
230228
if String.contains?(url, "count") and String.contains?(url, "total") do
231229
{:ok,
@@ -244,7 +242,8 @@ defmodule PostPostsTest do
244242
)
245243
|> Mox.expect(
246244
:post,
247-
stub_posts_translatable_calls,
245+
# title, desc, and body
246+
3,
248247
fn url, body, _params ->
249248
assert String.contains?(url, "https://translation.googleapis.com/")
250249

elixir-api/test/translate_test.exs

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ defmodule TranslateTest do
5656
stub_post = TestFixtures.stub_post()
5757
stub_posts = TestFixtures.stub_posts()
5858
stub_invalid = %{"someKey" => "someValue"}
59+
stub_translated_text = "someTranslatedText"
5960

6061
Hexerei.HTTP.MockClient
6162
|> Mox.stub(
@@ -71,7 +72,7 @@ defmodule TranslateTest do
7172
data: %{
7273
translations: [
7374
%{
74-
translatedText: "someTranslatedText"
75+
translatedText: stub_translated_text
7576
}
7677
]
7778
}
@@ -108,31 +109,24 @@ defmodule TranslateTest do
108109
|> List.first()
109110
|> Map.get("children")
110111
|> List.first()
111-
|> Map.get("text") == "someTranslatedText"
112+
|> Map.get("text") == stub_translated_text
112113

113114
assert is_map(translated_post)
114115

115116
assert translated_post["result"]["body"]
116117
|> List.first()
117118
|> Map.get("children")
118119
|> List.first()
119-
|> Map.get("text") == "someTranslatedText"
120+
|> Map.get("text") == stub_translated_text
120121

121122
assert is_map(translated_posts)
122-
# Posts should not have their body translated
123+
# Posts should have their body translated
123124
assert translated_posts["result"]
124125
|> List.first()
125126
|> Map.get("body")
126127
|> List.first()
127128
|> Map.get("children")
128129
|> List.first()
129-
|> Map.get("text") ==
130-
stub_posts["result"]
131-
|> List.first()
132-
|> Map.get("body")
133-
|> List.first()
134-
|> Map.get("children")
135-
|> List.first()
136-
|> Map.get("text")
130+
|> Map.get("text") == stub_translated_text
137131
end
138132
end

0 commit comments

Comments
 (0)