Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making it easier to use created_at, modified_at filter parameters #320

Open
znatty22 opened this issue May 9, 2018 · 0 comments
Labels
feature New functionality refactor Something needs to be done better

Comments

@znatty22
Copy link
Member

znatty22 commented May 9, 2018

Since created_at and modified_at use the default marshmallow datetime field, its very hard to pass filter parameter validation. As noted before in #188, Marshmallow has issues deserializing datetime fields bc it doesn't ever hit the logic which uses dateutils parser (which is much better at parsing various formats of datetime).

We should consider using our custom marshmallow datetime field for created_at and modified_at in our base schema.

Additionally, we may want to allow people to search by just dates rather than exact timestamp when using created_at, modified_at filter parameters.

@znatty22 znatty22 added feature New functionality refactor Something needs to be done better labels May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality refactor Something needs to be done better
Projects
None yet
Development

No branches or pull requests

1 participant