Skip to content

refactor: share compiler IN clause fragments#21

Open
kholdrex wants to merge 2 commits into
masterfrom
refactor/compiler-in-clause-fragments
Open

refactor: share compiler IN clause fragments#21
kholdrex wants to merge 2 commits into
masterfrom
refactor/compiler-in-clause-fragments

Conversation

@kholdrex

@kholdrex kholdrex commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Summary

Refactors the compiler string builder so top-level and related-subquery IN filters share the same fragment construction path. This keeps parameter lookup, array validation, placeholder numbering, and bind metadata consistent while reducing duplicate compiler logic.

Changes

  • Extracts shared IN clause fragment construction into a private compiler helper.
  • Reuses the helper for both normal filters and related subquery filters.
  • Adds regression coverage for placeholder and bind ordering around top-level and subquery IN filters.

Test Plan

  • Compiler specs passed.
  • Full RSpec suite passed.
  • RuboCop passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant