Skip to content

refactor: extract compiler bind spec helpers#17

Merged
kholdrex merged 1 commit into
masterfrom
refactor/compiler-bind-spec-helpers
Jun 3, 2026
Merged

refactor: extract compiler bind spec helpers#17
kholdrex merged 1 commit into
masterfrom
refactor/compiler-bind-spec-helpers

Conversation

@kholdrex

@kholdrex kholdrex commented Jun 3, 2026

Copy link
Copy Markdown
Owner

Summary

Refactors the compiler's bind-spec construction so repeated key and bind metadata handling is centralized in small private helpers. The change preserves existing SQL generation and parameter binding behavior while making the compiler easier to maintain before future compiler work.

Changes

  • Adds private helpers for filter bind keys, HAVING bind keys, and bind-spec appends.
  • Replaces repeated inline bind-spec hash construction across Arel, string, subquery, policy, and HAVING paths.
  • Keeps existing bind ordering, casts, parameter names, and generated query behavior unchanged.

Test Plan

  • Focused compiler specs passed.
  • Full RSpec suite passed.
  • RuboCop passed.
  • Independent review found no blocking findings.

@kholdrex kholdrex merged commit 843440a into master Jun 3, 2026
34 checks passed
@kholdrex kholdrex deleted the refactor/compiler-bind-spec-helpers branch June 3, 2026 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant