Skip to content

refactor: extract Arel compiler clause helpers#16

Merged
kholdrex merged 1 commit into
masterfrom
refactor/compiler-arel-clause-helpers
Jun 3, 2026
Merged

refactor: extract Arel compiler clause helpers#16
kholdrex merged 1 commit into
masterfrom
refactor/compiler-arel-clause-helpers

Conversation

@kholdrex

@kholdrex kholdrex commented Jun 3, 2026

Copy link
Copy Markdown
Owner

Summary

Extracts the Arel compiler clause-building logic into focused private helpers while preserving generated SQL and bind semantics. This continues the compiler refactor work by reducing the size of the main Arel compilation path without changing behavior.

Changes

  • Moves Arel SELECT/projection and DISTINCT handling into dedicated helper methods.
  • Moves Arel ORDER BY, GROUP BY, and HAVING application into dedicated helper methods.
  • Keeps existing bind ordering and fallback behavior unchanged.

Test plan

  • Ruby syntax check passed for the compiler.
  • RuboCop passed for the changed compiler file.
  • Focused compiler specs passed.
  • Full RSpec suite passed.

@kholdrex kholdrex merged commit bf77655 into master Jun 3, 2026
67 of 68 checks passed
@kholdrex kholdrex deleted the refactor/compiler-arel-clause-helpers branch June 3, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant