Add model tests

Author: khasinski

app/models/pet.rb

@@ -33,10 +33,10 @@ class Pet < ApplicationRecord
   validates :weight, numericality: { greater_than: 0 }
 
   def image_url(width: 100, height: 100)
-    if pet_type == "dog"
-      "https://placedog.net/#{width}/#{height}?id=#{id % 230}"
+    if dog?
+      "https://placedog.net/#{width}/#{height}?id=#{(id || 0) % 230}"
     else
-      "https://placekitten.com/#{width}/#{height}?image=#{id % 16}"
+      "https://placekitten.com/#{width}/#{height}?image=#{(id || 0) % 16}"
     end
   end
 
@@ -53,18 +53,22 @@ def similiar_name_pets
   end
 
   def tagline
-    if pet_type == "dog"
+    if dog?
       "#{name} is a #{age} year old #{breed} looking for a home!"
     else
       JSON.parse(Net::HTTP.get(URI("https://catfact.ninja/fact")))["fact"]
     end
   end
 
   def promo
-    if pet_type == "dog"
+    if dog?
       Net::HTTP.get(URI("http://localhost:3000/mock/slow-service"))
     else
       Net::HTTP.get(URI("http://localhost:3000/mock/outlier/#{id}"))
     end
   end
+
+  def dog?
+    pet_type == "dog"
+  end
 end

spec/models/pet_spec.rb

@@ -0,0 +1,68 @@
+require 'rails_helper'
+
+RSpec.describe Pet, type: :model do
+  describe "validations" do
+    it "requires a name" do
+      pet = Pet.new
+      pet.valid?
+      expect(pet.errors.messages).to have_key(:name)
+    end
+
+    it "requires an age" do
+      pet = Pet.new
+      pet.valid?
+      expect(pet.errors.messages).to have_key(:age)
+    end
+
+    it "requires a breed" do
+      pet = Pet.new
+      pet.valid?
+      expect(pet.errors.messages).to have_key(:breed)
+    end
+
+    it "requires a color" do
+      pet = Pet.new
+      pet.valid?
+      expect(pet.errors.messages).to have_key(:color)
+    end
+
+    it "requires a weight" do
+      pet = Pet.new
+      pet.valid?
+      expect(pet.errors.messages).to have_key(:weight)
+    end
+
+    it "requires a weight greater than 0" do
+      pet = Pet.new(weight: 0)
+      pet.valid?
+      expect(pet.errors.messages).to have_key(:weight)
+    end
+  end
+
+  describe "methods" do
+    describe "#image_url" do
+      it "returns a dog image url for dogs" do
+        pet = Pet.new(pet_type: "dog")
+        expect(pet.image_url).to include("https://placedog.net")
+      end
+
+      it "returns a cat image url for cats" do
+        pet = Pet.new(pet_type: "cat")
+        expect(pet.image_url).to include("https://placekitten.com")
+      end
+    end
+
+    describe "#tagline" do
+      it "returns a dog tagline for dogs" do
+        pet = Pet.new(pet_type: "dog", name: "Fido", age: 5, breed: "Golden Retriever")
+        expect(pet.tagline).to eq("Fido is a 5 year old Golden Retriever looking for a home!")
+      end
+
+      it "returns a cat fact for cats" do
+        allow(Net::HTTP).to receive(:get).and_return('{"fact": "Cats are cool"}')
+        pet = Pet.new(pet_type: "cat")
+        expect(pet.tagline).to eq("Cats are cool")
+      end
+    end
+  end
+end

spec/models/pet_view_spec.rb

@@ -1,5 +1,9 @@
 require 'rails_helper'
 
 RSpec.describe PetView, type: :model do
-  pending "add some examples to (or delete) #{__FILE__}"
+  it "validates presence of pet" do
+    pet_view = PetView.new
+    pet_view.valid?
+    expect(pet_view.errors.messages).to have_key(:pet)
+  end
 end