Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--one_outlier_per_iter default changed #56

Open
kfuku52 opened this issue Jul 1, 2021 · 3 comments
Open

--one_outlier_per_iter default changed #56

kfuku52 opened this issue Jul 1, 2021 · 3 comments
Assignees

Comments

@kfuku52
Copy link
Owner

kfuku52 commented Jul 1, 2021

12bf987
@Hego-CCTB This commit changes the default of --one_outlier_per_iter to 'no', to maintain the original behavior. We can activate it by default if its performance is consistently better, but I think we don't have any performance comparison yet.

@kfuku52
Copy link
Owner Author

kfuku52 commented Mar 7, 2023

@Hego-CCTB I will take care of it if you don't have time.

@Hego-CCTB
Copy link
Collaborator

I'll make a performance comparison, this shouldn't take too long. In terms of computing time, --one_outlier_per_iter to 'no' should always be at least equal or faster than 'yes', as there are fewer iterations involved. For actual quality, we'll need to see the amalgkit results.
I'll run a couple of datasets in both modes and post the statistics here.

@kfuku52
Copy link
Owner Author

kfuku52 commented Jul 8, 2024

Have you had a chance to investigate this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants