Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding delta PCC to AMALGKIT output #152

Open
Hego-CCTB opened this issue Oct 7, 2024 · 4 comments
Open

Adding delta PCC to AMALGKIT output #152

Hego-CCTB opened this issue Oct 7, 2024 · 4 comments
Assignees

Comments

@Hego-CCTB
Copy link
Collaborator

I added delta PCC to the AMALGKIT output as shown on the paper figure, like this:
uncorrected
Malus_domestica.2.correlation_cutoff.pdf
corrected
Malus_domestica.2.correlation_cutoff.sva.pdf

I also added a table to the output, which contains mean PCC, median PCC and variance for each boxplot category (bwbw, bwwi, wiwi, wibw) and each round. This is the data I used for the cross-species delta PCC plots of the paper figure. Here's how the table looks like:
Malus_domestica.sva.correlation_statistics.zip

Should I add these plots to csca output?

If it is OK like this, I'll push the update!

@Hego-CCTB Hego-CCTB self-assigned this Oct 7, 2024
@kfuku52
Copy link
Owner

kfuku52 commented Oct 8, 2024

The plot looks good, and the table would be useful. Please proceed with pushing the update. I also look forward to the csca update as well.

@Hego-CCTB
Copy link
Collaborator Author

36428a5

I added the PCC plots to csca as well! This is how they look like:
csca_delta_pcc_boxplot.pdf

The style is a bit different from the figure I made for the paper since those plots were done in Python, but now the styles are consistent between the PCC and delta PCC plots.

@kfuku52
Copy link
Owner

kfuku52 commented Oct 30, 2024

Thank you! If "Group" refers to the sample_group column, using "Sample group" will make its meaning clearer. Some of the curate plots may still display legacy labels like "Organ", but they should now be updated to "Sample group" as well. Could you please make these corrections?

@Hego-CCTB
Copy link
Collaborator Author

Good points! I'll update the PCC plots and legacy labels!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants