serializer-gson: Align order of Style with Vanilla output

Author: zml2008

text-serializer-gson/src/main/java/net/kyori/adventure/text/serializer/gson/StyleSerializer.java

@@ -38,6 +38,8 @@
 import java.io.IOException;
 import java.io.StringReader;
 import java.lang.reflect.Type;
+import java.util.EnumSet;
+import java.util.Set;
 import net.kyori.adventure.key.Key;
 import net.kyori.adventure.text.Component;
 import net.kyori.adventure.text.event.ClickEvent;
@@ -49,7 +51,27 @@
 import org.checkerframework.checker.nullness.qual.Nullable;
 
 final class StyleSerializer implements JsonDeserializer<Style>, JsonSerializer<Style> {
-  private static final TextDecoration[] DECORATIONS = TextDecoration.values();
+  @SuppressWarnings("checkstyle:NoWhitespaceAfter")
+  private static final TextDecoration[] DECORATIONS = {
+    // The order here is important -- Minecraft does string comparisons of some
+    // serialized components so we have to make sure our order matches Vanilla
+    TextDecoration.BOLD,
+    TextDecoration.ITALIC,
+    TextDecoration.UNDERLINED,
+    TextDecoration.STRIKETHROUGH,
+    TextDecoration.OBFUSCATED
+  };
+
+  static {
+    // Ensure coverage of decorations
+    final Set<TextDecoration> knownDecorations = EnumSet.allOf(TextDecoration.class);
+    for(final TextDecoration decoration : DECORATIONS) {
+      knownDecorations.remove(decoration);
+    }
+    if(!knownDecorations.isEmpty()) {
+      throw new IllegalStateException("GSON serializer is missing some text decorations: " + knownDecorations);
+    }
+  }
 
   static final String FONT = "font";
   static final String COLOR = "color";
@@ -183,16 +205,6 @@ private Codec.Decoder<Component, String, JsonParseException> decoder(final JsonD
   public JsonElement serialize(final Style src, final Type typeOfSrc, final JsonSerializationContext context) {
     final JsonObject json = new JsonObject();
 
-    final @Nullable Key font = src.font();
-    if(font != null) {
-      json.add(FONT, context.serialize(font));
-    }
-
-    final @Nullable TextColor color = src.color();
-    if(color != null) {
-      json.add(COLOR, context.serialize(color));
-    }
-
     for(int i = 0, length = DECORATIONS.length; i < length; i++) {
       final TextDecoration decoration = DECORATIONS[i];
       final TextDecoration.State state = src.decoration(decoration);
@@ -203,6 +215,11 @@ public JsonElement serialize(final Style src, final Type typeOfSrc, final JsonSe
       }
     }
 
+    final @Nullable TextColor color = src.color();
+    if(color != null) {
+      json.add(COLOR, context.serialize(color));
+    }
+
     final @Nullable String insertion = src.insertion();
     if(insertion != null) {
       json.addProperty(INSERTION, insertion);
@@ -228,6 +245,11 @@ public JsonElement serialize(final Style src, final Type typeOfSrc, final JsonSe
       json.add(HOVER_EVENT, eventJson);
     }
 
+    final @Nullable Key font = src.font();
+    if(font != null) {
+      json.add(FONT, context.serialize(font));
+    }
+
     return json;
   }