Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in CLManager GetTimeFrameRatesAsync #2

Open
spbarnes opened this issue Aug 24, 2021 · 0 comments
Open

Bug in CLManager GetTimeFrameRatesAsync #2

spbarnes opened this issue Aug 24, 2021 · 0 comments

Comments

@spbarnes
Copy link

GetTimeFrameRatesAsync in CLManager has a bug the end date parameter is being set to the start date the corrected function is below

    public async Task<CLTimeFrameResponse> GetTimeFrameRatesAsync(DateTime startDate, DateTime endDate, string sourceCurrency, IEnumerable<string> currencies)
    {
        Dictionary<string, string> parameters = new Dictionary<string, string>();

        parameters.AddStartDate(startDate);
        parameters.AddEndDate(endDate);
        parameters.AddCurrencies(currencies);
        parameters.AddSourceCurrency(sourceCurrency);

        return await RequestAsync<CLTimeFrameResponse>(Endpoints.TIMEFRAME, parameters);
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant