Skip to content

Commit 0fa9f17

Browse files
committed
Merge bitcoin#29535: ci: Fix functional tests step for pull requests in Windows GHA job
57e6e22 ci: Fix functional tests step for pull requests in Windows GHA job (Hennadii Stepanov) Pull request description: This functionality has been broken since the Windows runner image version `20240128.1.0`. Fixes bitcoin#29534. ACKs for top commit: fanquake: I can ACK 57e6e22 this only based on the fact that in this PR, the native Windows functional tests run: https://github.com/bitcoin/bitcoin/actions/runs/8119259315/job/22194887783#step:27:72, and that the native Windows functional tests are not currently running on master: https://github.com/bitcoin/bitcoin/actions/runs/8131828989/job/22239779585#step:27:63. hebasto: > I can ACK 57e6e22 m3dwards: ACK bitcoin@57e6e22 as a way to get the tests running again quickly. Tree-SHA512: 03e04fb96292e31ca0a8057e91b57f0812df92589f52f0602844e151ec5ec296badf5e549b1b606bab85607a3f9cd6abdfd328df80bf268501b537a596db0d96
2 parents faff279 + 57e6e22 commit 0fa9f17

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,4 +289,5 @@ jobs:
289289
- name: Run functional tests
290290
env:
291291
TEST_RUNNER_EXTRA: ${{ github.event_name != 'pull_request' && '--extended' || '' }}
292-
run: py -3 test\functional\test_runner.py --jobs $env:NUMBER_OF_PROCESSORS --ci --quiet --tmpdirprefix=$env:RUNNER_TEMP --combinedlogslen=99999999 --timeout-factor=$env:TEST_RUNNER_TIMEOUT_FACTOR $env:TEST_RUNNER_EXTRA
292+
shell: cmd
293+
run: py -3 test\functional\test_runner.py --jobs %NUMBER_OF_PROCESSORS% --ci --quiet --tmpdirprefix=%RUNNER_TEMP% --combinedlogslen=99999999 --timeout-factor=%TEST_RUNNER_TIMEOUT_FACTOR% %TEST_RUNNER_EXTRA%

0 commit comments

Comments
 (0)