netdev-offload-dpdk: Change log level.

Previously when a flow was attempted to be offloaded, if it
returned an error that was not an actions error, a warning was logged.

The reason there was an exception for an actions error was to allow
for failure for full offload of a flow because it will fallback to
partial offload. In this case the log level is debug.

The issue is that some NICs do not specify an actions error, because
other config in the NIC may be checked first. e.g. In the case of
Mellanox CX-5, an unspecified error may be returned because the NIC
is not configured for the requested offload.

This makes for noisey warnings, which may not be relevant, similar to
when the actions error is returned, as there may not be an expectation
that full offload will ever succeed.

Reduce log level for the other errors to debug to match that of the
actions type.

The status of the offload can still be seen with below command:

$ ovs-appctl dpctl/dump-flows -m
... offloaded:partial ...

Signed-off-by: Kevin Traynor <[email protected]>

Author: kevintraynor

lib/netdev-offload-dpdk.c

@@ -924,17 +924,12 @@ netdev_offload_dpdk_flow_create(struct netdev *netdev,
                         netdev_dpdk_get_port_id(netdev), ds_cstr(&s));
         }
     } else {
-        enum vlog_level level = VLL_WARN;
-
-        if (error->type == RTE_FLOW_ERROR_TYPE_ACTION) {
-            level = VLL_DBG;
-        }
-        VLOG_RL(&rl, level, "%s: rte_flow creation failed: %d (%s).",
+        VLOG_DBG_RL(&rl, "%s: rte_flow creation failed: %d (%s).",
                 netdev_get_name(netdev), error->type, error->message);
-        if (!vlog_should_drop(&this_module, level, &rl)) {
+        if (!vlog_should_drop(&this_module, VLL_DBG, &rl)) {
             dump_flow(&s, &s_extra, attr, flow_patterns, flow_actions);
             extra_str = ds_cstr(&s_extra);
-            VLOG_RL(&rl, level, "%s: Failed flow: %s  flow create %d %s",
+            VLOG_DBG_RL(&rl, "%s: Failed flow: %s  flow create %d %s",
                     netdev_get_name(netdev), extra_str,
                     netdev_dpdk_get_port_id(netdev), ds_cstr(&s));
         }