8362291: [macOS] Remove finalize method in CGraphicsEnvironment.java

Reviewed-by: bchristi, serb, kizune

Author: prrace

src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java

@@ -37,6 +37,8 @@
 import java.util.ListIterator;
 import java.util.Map;
 
+import sun.java2d.Disposer;
+import sun.java2d.DisposerRecord;
 import sun.java2d.SunGraphicsEnvironment;
 
 /**
@@ -82,7 +84,7 @@ public static void init() { }
     /**
      * Remove the instance's registration with CGDisplayRemoveReconfigurationCallback()
      */
-    private native void deregisterDisplayReconfiguration(long context);
+    private static native void deregisterDisplayReconfiguration(long context);
 
     /** Available CoreGraphics displays. */
     private final Map<Integer, CGraphicsDevice> devices = new HashMap<>(5);
@@ -93,6 +95,7 @@ public static void init() { }
 
     /** Reference to the display reconfiguration callback context. */
     private final long displayReconfigContext;
+    private final Object disposerReferent = new Object();
 
     // list of invalidated graphics devices (those which were removed)
     private List<WeakReference<CGraphicsDevice>> oldDevices = new ArrayList<>();
@@ -114,6 +117,7 @@ public CGraphicsEnvironment() {
         if (displayReconfigContext == 0L) {
             throw new RuntimeException("Could not register CoreGraphics display reconfiguration callback");
         }
+        Disposer.addRecord(disposerReferent, new CGEDisposerRecord(displayReconfigContext));
     }
 
     /**
@@ -139,12 +143,14 @@ void _displayReconfiguration(int displayId, boolean removed) {
         rebuildDevices();
     }
 
-    @Override
-    @SuppressWarnings("removal")
-    protected void finalize() throws Throwable {
-        try {
-            super.finalize();
-        } finally {
+    private static class CGEDisposerRecord implements DisposerRecord {
+        private final long displayReconfigContext;
+
+        CGEDisposerRecord(long ptr) {
+            displayReconfigContext = ptr;
+        }
+
+        public void dispose() {
             deregisterDisplayReconfiguration(displayReconfigContext);
         }
     }

src/java.desktop/macosx/native/libawt_lwawt/awt/CGraphicsEnv.m

@@ -162,7 +162,7 @@
  */
 JNIEXPORT void JNICALL
 Java_sun_awt_CGraphicsEnvironment_deregisterDisplayReconfiguration
-(JNIEnv *env, jobject this, jlong p)
+(JNIEnv *env, jclass clazz, jlong p)
 {
 JNI_COCOA_ENTER(env);
 

src/java.desktop/share/classes/sun/java2d/Disposer.java

@@ -137,7 +137,7 @@ public void run() {
                 obj = null;
                 rec = null;
                 clearDeferredRecords();
-            } catch (Exception e) {
+            } catch (Throwable t) {
                 System.out.println("Exception while removing reference.");
             }
         }
@@ -157,7 +157,7 @@ public static interface PollDisposable {
     private static void safeDispose(DisposerRecord rec) {
         try {
             rec.dispose();
-        } catch (final Exception e) {
+        } catch (final Throwable t) {
             System.out.println("Exception while disposing deferred rec.");
         }
     }
@@ -212,7 +212,7 @@ public static void pollRemove() {
                     deferredRecords.offerLast(rec);
                 }
             }
-        } catch (Exception e) {
+        } catch (Throwable t) {
             System.out.println("Exception while removing reference.");
         } finally {
             pollingQueue = false;