Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include artifact for firebase remote config #3

Open
kevincianfarini opened this issue Oct 31, 2022 · 0 comments
Open

Include artifact for firebase remote config #3

kevincianfarini opened this issue Oct 31, 2022 · 0 comments
Labels
Help Wanted Core maintainers don't have a use case for this feature, and would accept a PR.

Comments

@kevincianfarini
Copy link
Owner

kevincianfarini commented Oct 31, 2022

My workplace no longer uses Firebase Remote Config to manage our feature flags, so this does not have as high of a priority as it once did. I am happy to accept PRs implementing this feature, but I see two major impediments:

  1. The Firebase Android SDK is an Android library and offers no JVM API that can be used outside of Android. This means that our module will have to declare an androidTarget sourceset, which is in flux.
  2. The Firebase Android SDK's main entrypoint -- FirebaseRemoteConfig.java -- offers no interface for us to program against. In effect this means that it would be impossible for us to test our integration with Firebase without having to perform IO and use a real firebase account. This is really gross.

Our implementation should strive to work solely on the JVM if possible, though not required. We will not accept tests which stipulate real network connections and a real firebase account. Overcoming this will likely require a feature request on the Firebase repo, an internal interface which we can control under test that's implemented with FirebaseRemoteConfig in production, or a clean-room implementation of the remote config SDK with the HTTP API.

@kevincianfarini kevincianfarini added the Help Wanted Core maintainers don't have a use case for this feature, and would accept a PR. label Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Core maintainers don't have a use case for this feature, and would accept a PR.
Projects
None yet
Development

No branches or pull requests

1 participant