Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kevin1024/vcrpy
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 936b84639e6a2e5b8ef3abd06aa6bdc5b7c45186
Choose a base ref
..
head repository: kevin1024/vcrpy
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d64cdd337bc4e812cd2b49b59609d3d1582b6590
Choose a head ref
Showing with 6 additions and 3 deletions.
  1. +1 −0 tests/integration/test_config.py
  2. +5 −3 vcr/cassette.py
1 change: 1 addition & 0 deletions tests/integration/test_config.py
Original file line number Diff line number Diff line change
@@ -82,6 +82,7 @@ def some_test():

assert not os.path.exists(str(tmpdir.join("dontsave2.yml")))


def test_set_drop_unused_requests(tmpdir, httpbin):
my_vcr = vcr.VCR(drop_unused_requests=True)
file = str(tmpdir.join("test.yaml"))
8 changes: 5 additions & 3 deletions vcr/cassette.py
Original file line number Diff line number Diff line change
@@ -348,8 +348,10 @@ def _new_interactions(self):
"""List of new HTTP interactions (request/response tuples)"""
new_interactions = []
for request, response in self.data:
if all(not requests_match(request, old_request, self._match_on)
for old_request, _ in self._old_interactions):
if all(
not requests_match(request, old_request, self._match_on)
for old_request, _ in self._old_interactions
):
new_interactions.append((request, response))
return new_interactions

@@ -363,7 +365,7 @@ def _as_dict(self):
return {"requests": requests, "responses": responses}

def _save(self, force=False):
if (len(self._played_interactions) < len(self._old_interactions)):
if len(self._played_interactions) < len(self._old_interactions):
force = True
if force or self.dirty:
self._persister.save_cassette(self._path, self._as_dict(), serializer=self._serializer)