From 0e5718220781ab0ce841aabbdd3d4dede9aa8cff Mon Sep 17 00:00:00 2001 From: Sebastian Pipping Date: Fri, 8 Dec 2023 22:54:58 +0100 Subject: [PATCH] setup.py: Block urllib3 >=2 for PyPy (including 3.10) It kept failing CI --- setup.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index 0afb8106b..37d1558a5 100644 --- a/setup.py +++ b/setup.py @@ -46,13 +46,15 @@ def run_tests(self): "PyYAML", "wrapt", "yarl", - # Support for urllib3 >=2 needs Python >=3.10 - # so we need to block urllib3 >=2 for Python <3.10 for now. + # Support for urllib3 >=2 needs CPython >=3.10 + # so we need to block urllib3 >=2 for Python <3.10 and PyPy for now. # Note that vcrpy would work fine without any urllib3 around, # so this block and the dependency can be dropped at some point # in the future. For more Details: # https://github.com/kevin1024/vcrpy/pull/699#issuecomment-1551439663 "urllib3 <2; python_version <'3.10'", + # https://github.com/kevin1024/vcrpy/pull/775#issuecomment-1847849962 + "urllib3 <2; platform_python_implementation =='PyPy'", ] tests_require = [