Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Recent changes introduced unittest dependency on a local redis server #128

@danrue

Description

@danrue

Before 2ded14f ("Add unit tests for test case import and regression"), unittests could be run without a redis server. 3 new tests introduced in the above commit fail if redis is not running:

======================================================================
ERROR: test_new_failure (utils.kci_test.tests.test_tests.TestTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/drue/src/kernelci/kernelci-backend/app/utils/kci_test/tests/test_tests.py", line 104, in test_new_failure
    ret, regr_ids = utils.kci_test.regressions.find(group_id, db=self._db)
  File "/home/drue/src/kernelci/kernelci-backend/app/utils/kci_test/regressions.py", line 167, in find
    with redis.lock.Lock(redis_conn, lock_key, timeout=5):
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/lock.py", line 84, in __enter__
    self.acquire(blocking=True)
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/lock.py", line 111, in acquire
    if self.do_acquire(token):
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/lock.py", line 121, in do_acquire
    if self.redis.setnx(self.name, token):
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/client.py", line 1196, in setnx
    return self.execute_command('SETNX', name, value)
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/client.py", line 673, in execute_command
    connection.send_command(*args)
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/connection.py", line 610, in send_command
    self.send_packed_command(self.pack_command(*args))
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/connection.py", line 585, in send_packed_command
    self.connect()
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/connection.py", line 489, in connect
    raise ConnectionError(self._error_message(e))
ConnectionError: Error 111 connecting to localhost:6379. Connection refused.

======================================================================
ERROR: test_no_regression (utils.kci_test.tests.test_tests.TestTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/drue/src/kernelci/kernelci-backend/app/utils/kci_test/tests/test_tests.py", line 162, in test_no_regression
    ret, regr_ids = utils.kci_test.regressions.find(group_id, db=self._db)
  File "/home/drue/src/kernelci/kernelci-backend/app/utils/kci_test/regressions.py", line 167, in find
    with redis.lock.Lock(redis_conn, lock_key, timeout=5):
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/lock.py", line 84, in __enter__
    self.acquire(blocking=True)
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/lock.py", line 111, in acquire
    if self.do_acquire(token):
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/lock.py", line 121, in do_acquire
    if self.redis.setnx(self.name, token):
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/client.py", line 1196, in setnx
    return self.execute_command('SETNX', name, value)
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/client.py", line 673, in execute_command
    connection.send_command(*args)
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/connection.py", line 610, in send_command
    self.send_packed_command(self.pack_command(*args))
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/connection.py", line 585, in send_packed_command
    self.connect()
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/connection.py", line 489, in connect
    raise ConnectionError(self._error_message(e))
ConnectionError: Error 111 connecting to localhost:6379. Connection refused.

======================================================================
ERROR: test_tracking_regression (utils.kci_test.tests.test_tests.TestTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/drue/src/kernelci/kernelci-backend/app/utils/kci_test/tests/test_tests.py", line 225, in test_tracking_regression
    ret, regrs = utils.kci_test.regressions.find(group_id, db=self._db)
  File "/home/drue/src/kernelci/kernelci-backend/app/utils/kci_test/regressions.py", line 167, in find
    with redis.lock.Lock(redis_conn, lock_key, timeout=5):
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/lock.py", line 84, in __enter__
    self.acquire(blocking=True)
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/lock.py", line 111, in acquire
    if self.do_acquire(token):
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/lock.py", line 121, in do_acquire
    if self.redis.setnx(self.name, token):
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/client.py", line 1196, in setnx
    return self.execute_command('SETNX', name, value)
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/client.py", line 673, in execute_command
    connection.send_command(*args)
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/connection.py", line 610, in send_command
    self.send_packed_command(self.pack_command(*args))
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/connection.py", line 585, in send_packed_command
    self.connect()
  File "/home/drue/src/kernelci/kernelci-backend/app/venv/lib/python2.7/site-packages/redis/connection.py", line 489, in connect
    raise ConnectionError(self._error_message(e))
ConnectionError: Error 111 connecting to localhost:6379. Connection refused.

Running a local redis server resolves this issue, but it should not be a requirement for running local unit tests.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions