As discussed in #2042, the webhook crashes when requests raises an exception other than requests.HTTPError
Expected behavior:
- requests raises an exception
- if safe to retry: log exception as warning and retry a limited amount of times
- if giving up (not safe to retry / max retries reached): log exception as error
Current behavior:
At a cursory examination, looks like it logs and gives up on requests.HTTPError, and crashes on other exceptions. In particular, #2042 introduced a timeout that may cause more frequent exceptions
As discussed in #2042, the webhook crashes when
requestsraises an exception other thanrequests.HTTPErrorExpected behavior:
Current behavior:
At a cursory examination, looks like it logs and gives up on
requests.HTTPError, and crashes on other exceptions. In particular, #2042 introduced a timeout that may cause more frequent exceptions