Skip to content

Commit c966139

Browse files
Chen Nianakryiko
Chen Ni
authored andcommitted
selftests/bpf: Convert comma to semicolon
Replace comma between expressions with semicolons. Using a ',' in place of a ';' can have unintended side effects. Although that is not the case here, it is seems best to use ';' unless ',' is intended. Found by inspection. No functional change intended. Compile tested only. Signed-off-by: Chen Ni <[email protected]> Signed-off-by: Andrii Nakryiko <[email protected]> Reviewed-by: Amery Hung <[email protected]> Link: https://lore.kernel.org/bpf/[email protected]
1 parent 893c393 commit c966139

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/testing/selftests/bpf/test_kmods/bpf_testmod.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -1340,7 +1340,7 @@ static int st_ops_gen_prologue_with_kfunc(struct bpf_insn *insn_buf, bool direct
13401340
*insn++ = BPF_STX_MEM(BPF_DW, BPF_REG_6, BPF_REG_7, offsetof(struct st_ops_args, a));
13411341
*insn++ = BPF_JMP_IMM(BPF_JA, 0, 0, 2);
13421342
*insn++ = BPF_MOV64_REG(BPF_REG_1, BPF_REG_0);
1343-
*insn++ = BPF_CALL_KFUNC(0, bpf_cgroup_release_id),
1343+
*insn++ = BPF_CALL_KFUNC(0, bpf_cgroup_release_id);
13441344
*insn++ = BPF_MOV64_REG(BPF_REG_1, BPF_REG_8);
13451345
*insn++ = prog->insnsi[0];
13461346

@@ -1379,7 +1379,7 @@ static int st_ops_gen_epilogue_with_kfunc(struct bpf_insn *insn_buf, const struc
13791379
*insn++ = BPF_STX_MEM(BPF_DW, BPF_REG_1, BPF_REG_6, offsetof(struct st_ops_args, a));
13801380
*insn++ = BPF_JMP_IMM(BPF_JA, 0, 0, 2);
13811381
*insn++ = BPF_MOV64_REG(BPF_REG_1, BPF_REG_0);
1382-
*insn++ = BPF_CALL_KFUNC(0, bpf_cgroup_release_id),
1382+
*insn++ = BPF_CALL_KFUNC(0, bpf_cgroup_release_id);
13831383
*insn++ = BPF_MOV64_REG(BPF_REG_0, BPF_REG_6);
13841384
*insn++ = BPF_ALU64_IMM(BPF_MUL, BPF_REG_0, 2);
13851385
*insn++ = BPF_EXIT_INSN();

0 commit comments

Comments
 (0)