Skip to content

Commit be0d5fa

Browse files
committed
certs: move the 'depends on' to the choice of module signing keys
When the condition "MODULE_SIG || (IMA_APPRAISE_MODSIG && MODULES)" is unmet, you cannot choose anything in the choice, but the choice menu is still displayed in the menuconfig etc. Move the 'depends on' to the choice to hide the meaningless menu. Also delete the redundant 'default'. In a choice, the first entry is the default. Signed-off-by: Masahiro Yamada <[email protected]>
1 parent 4dc0759 commit be0d5fa

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

certs/Kconfig

+1-3
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,19 @@ config MODULE_SIG_KEY
1717

1818
choice
1919
prompt "Type of module signing key to be generated"
20-
default MODULE_SIG_KEY_TYPE_RSA
20+
depends on MODULE_SIG || (IMA_APPRAISE_MODSIG && MODULES)
2121
help
2222
The type of module signing key type to generate. This option
2323
does not apply if a #PKCS11 URI is used.
2424

2525
config MODULE_SIG_KEY_TYPE_RSA
2626
bool "RSA"
27-
depends on MODULE_SIG || (IMA_APPRAISE_MODSIG && MODULES)
2827
help
2928
Use an RSA key for module signing.
3029

3130
config MODULE_SIG_KEY_TYPE_ECDSA
3231
bool "ECDSA"
3332
select CRYPTO_ECDSA
34-
depends on MODULE_SIG || (IMA_APPRAISE_MODSIG && MODULES)
3533
help
3634
Use an elliptic curve key (NIST P384) for module signing. Consider
3735
using a strong hash like sha256 or sha384 for hashing modules.

0 commit comments

Comments
 (0)