chore: fix all warnings

Author: kermanx

crates/tree_shaker/src/entity/array.rs

@@ -107,7 +107,7 @@ impl<'a> EntityTrait<'a> for ArrayEntity<'a> {
               result.push(analyzer.factory.unmatched_prototype_property);
             }
           }
-          LiteralEntity::Symbol(key, _) => todo!(),
+          LiteralEntity::Symbol(_key, _) => todo!(),
           _ => unreachable!("Invalid property key"),
         }
       }
@@ -192,7 +192,7 @@ impl<'a> EntityTrait<'a> for ArrayEntity<'a> {
               break 'known;
             }
           }
-          LiteralEntity::Symbol(key, _) => todo!(),
+          LiteralEntity::Symbol(_key, _) => todo!(),
           _ => unreachable!("Invalid property key"),
         }
       }

crates/tree_shaker/src/entity/builtin_fn.rs

@@ -210,12 +210,12 @@ impl<'a, F: BuiltinFnImplementation<'a> + 'a> BuiltinFnEntity<'a>
 impl<'a> Analyzer<'a> {
   pub fn dynamic_implemented_builtin<F: BuiltinFnImplementation<'a> + 'a>(
     &mut self,
-    name: &'static str,
+    _name: &'static str,
     implementation: F,
   ) -> Entity<'a> {
     self.factory.alloc(ImplementedBuiltinFnEntity {
       #[cfg(feature = "flame")]
-      name,
+      name: _name,
       implementation,
       object: Some(self.new_function_object()),
     })

crates/tree_shaker/src/entity/factory.rs

@@ -183,12 +183,12 @@ impl<'a> EntityFactory<'a> {
 
   pub fn implemented_builtin_fn<F: BuiltinFnImplementation<'a> + 'a>(
     &self,
-    name: &'static str,
+    _name: &'static str,
     implementation: F,
   ) -> Entity<'a> {
     self.alloc(ImplementedBuiltinFnEntity {
       #[cfg(feature = "flame")]
-      name,
+      name: _name,
       implementation,
       object: None,
     })

crates/tree_shaker/src/entity/mod.rs

@@ -12,7 +12,6 @@ mod never;
 mod object;
 mod primitive;
 mod react_element;
-mod symbol;
 mod typeof_result;
 mod union;
 mod unknown;

crates/tree_shaker/src/entity/object/init.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::unnecessary_unwrap)]
+
 use super::{ObjectEntity, ObjectProperty, ObjectPropertyValue};
 use crate::{
   analyzer::Analyzer,
@@ -79,7 +81,7 @@ impl<'a> ObjectEntity<'a> {
               existing.unwrap().possible_values.push(property_val);
             }
           }
-          LiteralEntity::Symbol(key, _) => todo!(),
+          LiteralEntity::Symbol(_key, _) => todo!(),
           _ => unreachable!("Invalid property key"),
         }
       }

crates/tree_shaker/src/nodes/expr/member_expression.rs

@@ -9,6 +9,9 @@ use oxc::{
   span::GetSpan,
 };
 
+pub type MemberExpressionReadResult<'a> =
+  Result<(usize, Entity<'a>, Option<Entity<'a>>, (Entity<'a>, Entity<'a>)), Entity<'a>>;
+
 impl<'a> Analyzer<'a> {
   /// Returns (short-circuit, value, cache)
   pub fn exec_member_expression_read(
@@ -30,7 +33,7 @@ impl<'a> Analyzer<'a> {
     &mut self,
     node: &'a MemberExpression<'a>,
     will_write: bool,
-  ) -> Result<(usize, Entity<'a>, Option<Entity<'a>>, (Entity<'a>, Entity<'a>)), Entity<'a>> {
+  ) -> MemberExpressionReadResult<'a> {
     let (mut scope_count, object, mut undefined) = self.exec_expression_in_chain(node.object())?;
 
     let dep_id = AstKind2::MemberExpression(node);

crates/tree_shaker/src/scope/exhaustive.rs

@@ -67,7 +67,7 @@ impl<'a> Analyzer<'a> {
 
   fn exec_exhaustively(
     &mut self,
-    kind: &str,
+    _kind: &str,
     runner: Rc<dyn Fn(&mut Analyzer<'a>) + 'a>,
     once: bool,
   ) -> FxHashSet<(VariableScopeId, SymbolId)> {
@@ -76,7 +76,7 @@ impl<'a> Analyzer<'a> {
     while self.cf_scope_mut().iterate_exhaustively() {
       #[cfg(feature = "flame")]
       let _scope_guard = flame::start_guard(format!(
-        "!{kind}@{:06X} x{}",
+        "!{_kind}@{:06X} x{}",
         (Rc::as_ptr(&runner) as *const () as usize) & 0xFFFFFF,
         round_counter
       ));