Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement of RWKV7 #2175

Closed
pass-lin opened this issue Mar 29, 2025 · 2 comments
Closed

implement of RWKV7 #2175

pass-lin opened this issue Mar 29, 2025 · 2 comments
Assignees

Comments

@pass-lin
Copy link
Contributor

from issue #21084
I want to submit the implementation of RW KV 7 for keras_hub, but it should be noted that RW KV 7 needs to submit the kernel implementation, otherwise it will run very slow. keras-team believes that the kernel implementation is not suitable for submitting to the keras repository. But is it suitable for submitting to the keras_hub repository

@sonali-kumari1 sonali-kumari1 added the type:feature New feature or request label Mar 29, 2025
@sachinprasadhs
Copy link
Collaborator

Hi,

Thank you for your interest in contributing to Keras Hub.

Given the relatively limited adoption of RW KV 7 at the moment, we're concerned that including it in Keras Hub might not attract substantial community involvement.

Therefore, we suggest initially implementing these changes within your own library. You're welcome to share a link to your library here in this issue thread.

We will continue to monitor the situation, and if we observe a growing demand for this feature, we'll definitely re-evaluate its potential inclusion in Keras or Keras Hub.

@pass-lin
Copy link
Contributor Author

pass-lin commented Apr 4, 2025

Hi,

Thank you for your interest in contributing to Keras Hub.

Given the relatively limited adoption of RW KV 7 at the moment, we're concerned that including it in Keras Hub might not attract substantial community involvement.

Therefore, we suggest initially implementing these changes within your own library. You're welcome to share a link to your library here in this issue thread.

We will continue to monitor the situation, and if we observe a growing demand for this feature, we'll definitely re-evaluate its potential inclusion in Keras or Keras Hub.

https://github.com/[pass-lin/RWKV7-Keras](https://github.com/pass-lin/RWKV7-Keras)

@pass-lin pass-lin closed this as completed Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants