Skip to content

Commit c2494ec

Browse files
authored
Apply suggestions from code review
1 parent b860932 commit c2494ec

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

docs/examples.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -555,7 +555,7 @@ $ ldapsearch -H ldap://localhost:389 -x -D cn=demo,dc=example,dc=com \
555555

556556
This example demonstrates multi-threading via the `cluster` module utilizing a `net` server for initial socket receipt. An alternate example demonstrating use of the `connectionRouter` `serverOptions` hook is available in the `examples` directory.
557557

558-
```
558+
```js
559559
const cluster = require('cluster');
560560
const ldap = require('ldapjs');
561561
const net = require('net');

lib/server.js

+2
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,8 @@ function Server (options) {
314314
}
315315

316316
self.newConnection = function (conn) {
317+
// TODO: make `newConnection` available on the `Server` prototype
318+
// https://github.com/ldapjs/node-ldapjs/pull/727/files#r636572294
317319
setupConnection(conn)
318320
log.trace('new connection from %s', conn.ldap.id)
319321

0 commit comments

Comments
 (0)