Fix toBer result

Author: jsumners

Diff for: index.js

@@ -3,6 +3,7 @@
 const { core: { LBER_SET } } = require('@ldapjs/protocol')
 const {
   BerTypes,
+  BerReader,
   BerWriter
 } = require('@ldapjs/asn1')
 const warning = require('./lib/deprecations')
@@ -161,7 +162,7 @@ class Attribute {
    * Convert the {@link Attribute} instance to a {@link BerReader} capable of
    * being used in an LDAP message.
    *
-   * @returns {BerWriter}
+   * @returns {BerReader}
    */
   toBer () {
     const ber = new BerWriter()
@@ -182,7 +183,7 @@ class Attribute {
     ber.endSequence()
     ber.endSequence()
 
-    return ber
+    return new BerReader(ber.buffer)
   }
 
   toJSON () {

Diff for: index.test.js

@@ -181,9 +181,7 @@ tap.test('toBer', async t => {
       type: 'cn',
       values: ['foo', 'bar']
     })
-    const ber = attr.toBer()
-
-    const reader = new BerReader(ber.buffer)
+    const reader = attr.toBer()
     t.ok(reader.readSequence())
     t.equal(reader.readString(), 'cn')
     t.equal(reader.readSequence(LBER_SET), LBER_SET)
@@ -193,9 +191,7 @@ tap.test('toBer', async t => {
 
   t.test('renders type without values', async t => {
     const attr = new Attribute({ type: 'cn' })
-    const ber = attr.toBer()
-
-    const reader = new BerReader(ber.buffer)
+    const reader = attr.toBer()
     t.ok(reader.readSequence())
     t.equal(reader.readString(), 'cn')
     t.equal(reader.readSequence(LBER_SET), LBER_SET)

Diff for: package.json

@@ -7,7 +7,7 @@
   "name": "@ldapjs/attribute",
   "homepage": "https://github.com/ldapjs/attribute",
   "description": "API for handling LDAP entry attributes",
-  "version": "1.0.0-rc.3",
+  "version": "1.0.0-rc.4",
   "license": "MIT",
   "repository": {
     "type": "git",