Skip to content

Commit 87cd53e

Browse files
committed
Rollup merge of rust-lang#49965 - nikic:fix-49622, r=rkruppe
Remove warning about f64->f32 cast being potential UB As discussed in rust-lang#15536, the LLVM documentation incorrect described overflowing f64->f32 casts as being undefined behavior. LLVM never treated them as such, and the documentation has been adjusted in https://reviews.llvm.org/rL329065. As such, this warning can now be removed. Closes rust-lang#49622. --- I could not find any existing test checking for this warning. Should I be adding a test for the absence of the warning instead?
2 parents 34ee31d + cbabb1b commit 87cd53e

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

src/librustc_typeck/check/demand.rs

-4
Original file line numberDiff line numberDiff line change
@@ -502,10 +502,6 @@ impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> {
502502
&format!("{}, producing the closest possible value",
503503
msg),
504504
cast_suggestion);
505-
err.warn("casting here will cause undefined behavior if the value is \
506-
finite but larger or smaller than the largest or smallest \
507-
finite value representable by `f32` (this is a bug and will be \
508-
fixed)");
509505
}
510506
true
511507
}

0 commit comments

Comments
 (0)