Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to load on 1.21 #195

Open
DBTDerpbox opened this issue Jul 29, 2024 · 22 comments
Open

Fails to load on 1.21 #195

DBTDerpbox opened this issue Jul 29, 2024 · 22 comments

Comments

@DBTDerpbox
Copy link

Describe the bug

The plugin is unable to load in 1.21 in its current state. This results in all of its functionality being unavailable.

To Reproduce

  • Set up a Paper 1.21 server
  • Add the plugin
  • Error appears in log
[16:34:06 INFO]: [CForms] Enabling CrossplatForms v1.5.0
[16:34:06 ERROR]: Error occurred while enabling CrossplatForms v1.5.0 (Is it up to date?)
java.lang.ExceptionInInitializerError: null
        at CrossplatForms-Spigot.jar/dev.kejona.crossplatforms.spigot.CrossplatFormsSpigot.findVersionAdapter(CrossplatFormsSpigot.java:28) ~[CrossplatForms-Spigot.jar:?]
        at CrossplatForms-Spigot.jar/dev.kejona.crossplatforms.spigot.SpigotBase.onEnable(SpigotBase.java:80) ~[CrossplatForms-Spigot.jar:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:288) ~[paper-api-1.21-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:202) ~[paper-1.21.jar:1.21-119-100d75a]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[paper-1.21.jar:1.21-119-100d75a]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[paper-api-1.21-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:640) ~[paper-1.21.jar:1.21-119-100d75a]
        at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:589) ~[paper-1.21.jar:1.21-119-100d75a]
        at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:754) ~[paper-1.21.jar:1.21-119-100d75a]
        at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:516) ~[paper-1.21.jar:1.21-119-100d75a]
        at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:329) ~[paper-1.21.jar:1.21-119-100d75a]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1215) ~[paper-1.21.jar:1.21-119-100d75a]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:330) ~[paper-1.21.jar:1.21-119-100d75a]
        at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 3 out of bounds for length 3
        at CrossplatForms-Spigot.jar/dev.kejona.crossplatforms.spigot.ClassNames.<clinit>(ClassNames.java:25) ~[CrossplatForms-Spigot.jar:?]
        ... 14 more
[16:34:06 INFO]: [CForms] Disabling CrossplatForms v1.5.0

Expected behaviour

The plugin would not give an error and would allow server admins and players to use its features.

Screenshots / Videos

No response

Server Version and Plugins

Paper 1.21-119-master@100d75a (2024-07-29T16:00:13Z) (Implementing API version 1.21-R0.1-SNAPSHOT)

Geyser Dump

https://dump.geysermc.org/mg8VxiD53kq8qQik350QMnfOxpYz3LP2

CrossplatForms Version

1.5.0

Additional Context

latest.log

@ZherKing
Copy link

I am also waiting for the fix of this issue

@MiguVT
Copy link

MiguVT commented Jul 30, 2024

me too, there is a 1.21 branch i will try to compile to see if it fixs it

@MiguVT
Copy link

MiguVT commented Jul 30, 2024

♥️ I will try it now, i was updating all my server plugins, lets check if it works (Remember, its a snapshot of a version that is not released, it can contain bugs but there is no updates on the version in the last month, so i think it works fine with no bugs.

@Jens-Co
Copy link
Member

Jens-Co commented Jul 30, 2024

The compiled jar from this branch should work on 1.21 server, it's not yet in master as i did not had time to properly test it. I lack the time to properly implement the 1.21 or 1.20.6 for that matter.

If you have question feel free to ask.

@MiguVT
Copy link

MiguVT commented Jul 30, 2024

Its working, no bugs atm, if i find some bugs i will report it here and make a PR if i can fix it

@Jens-Co
Copy link
Member

Jens-Co commented Jul 30, 2024

Great thanks, the main issue lies in the nms, we should be looking for a way to remove nms completely in the future.

@DBTDerpbox
Copy link
Author

I'm not sure why I didn't bother checking to see if there was an updated branch, thank you

@MiguVT
Copy link

MiguVT commented Aug 23, 2024

lack the time to properly implement the 1.21 or

I was using it a month and everything is working without bugs or errors (purpur 1.21) ♥️

@kejonaMC kejonaMC deleted a comment from MiguVT Aug 29, 2024
@kejonaMC kejonaMC deleted a comment from MiguVT Aug 29, 2024
@Konicai
Copy link
Member

Konicai commented Aug 29, 2024

If you have a fix for anything you can create a PR, which will provide downloads. Please do NOT link external jar downloads of any type here.

@MiguVT
Copy link

MiguVT commented Aug 29, 2024

If you have a fix for anything you can create a PR, which will provide downloads. Please do NOT link external jar downloads of any type here.

Oh ok, sorry, i dont fixed anything, i just compiled it, can you upload or run an action for get the 1.21 CrossplatForms download?? tysm, too much servers use it and i know how to compile but too many people dont know.

@Jens-Co

This comment was marked as outdated.

@kejonaMC kejonaMC deleted a comment from MiguVT Sep 1, 2024
@kejonaMC kejonaMC deleted a comment from ZherKing Sep 1, 2024
@Konicai
Copy link
Member

Konicai commented Sep 1, 2024

Use the builds available on https://ci.kejonamc.dev/job/CrossplatForms/job/dev/ please

@DBTDerpbox
Copy link
Author

Coming back to this, you're probably aware but the latest development build (using https://ci.kejonamc.dev/job/CrossplatForms/job/dev/) is incompatible with 1.21.3, not sure if this should of been a new issue or not, so I'm sorry if it should of been

Log:
latest.log

@MiguVT
Copy link

MiguVT commented Nov 10, 2024

Rn we don't need to request an update, it should be an issue when stable 1.21.3 paper released

@VincentX0905
Copy link

Where is the 1.21.0/1 1.21.2 update?
Now it is version 1.21.3
1.21.4 will be released in a few weeks.

When will it be updated? @Konicai

@VincentX0905
Copy link

VincentX0905 commented Dec 14, 2024

I created version 1.21.3 of the plugin
Remember: This is just a hotfix and will not replace future versions.(so you can update first)
Please wait for the author's maintenance version for the official version

Hotfix Version
Select "Actions" in the upper navigation bar -> Select the latest workflows --> Check out the Artifacts below and download and unzip it [need login]

If you have any questions please open an issue in my repository
I will try to update to 1.21.4 in the next few days

In versions after 1.20.5, PaperMC has removed the NMS acquisition method.
Therefore, you cannot use Bukkit.getServer().getClass().getPackage().getName() to obtain the NMS version on PaperMC or PaperMC branch (purpur etc.) servers.
Announcement link

@wykwey
Copy link

wykwey commented Dec 14, 2024

I created version 1.21.3 of the plugin Remember: This is just a hotfix and will not replace future versions.(so you can update first) Please wait for the author's maintenance version for the official version

Hotfix Version Select "Actions" in the upper navigation bar -> Select the latest workflows --> Check out the Artifacts below and download and unzip it

If you have any questions please open an issue in my repository I will try to update to 1.21.4 in the next few days

In versions after 1.20.5, PaperMC has removed the NMS acquisition method.
Therefore, you cannot use Bukkit.getServer().getClass().getPackage().getName() to obtain the NMS version on PaperMC or PaperMC branch (purpur etc.) servers.
Announcement link

Can you build and publish a jar

@VincentX0905
Copy link

VincentX0905 commented Dec 14, 2024

I created version 1.21.3 of the plugin Remember: This is just a hotfix and will not replace future versions.(so you can update first) Please wait for the author's maintenance version for the official version
Hotfix Version Select "Actions" in the upper navigation bar -> Select the latest workflows --> Check out the Artifacts below and download and unzip it
If you have any questions please open an issue in my repository I will try to update to 1.21.4 in the next few days

In versions after 1.20.5, PaperMC has removed the NMS acquisition method.
Therefore, you cannot use Bukkit.getServer().getClass().getPackage().getName() to obtain the NMS version on PaperMC or PaperMC branch (purpur etc.) servers.
Announcement link

Can you build and publish a jar

Just check out https://github.com/VincentX0905/CrossplatForms-new/actions
And read #195 (comment)
If you don't look carefully, you won't be able to get the Jar file

@Jens-Co
Copy link
Member

Jens-Co commented Dec 14, 2024

e any questions please open an issue in my repository I will try to update to 1.21.4 in the next few days

In versions after 1.20.5, PaperMC has removed the NM

Hello Vincent, i totally missed papers announcement about that one. There is currently a dev branch that had working plugin, I lack the time to look into some other isssues aswel for example the nms location of craftplayer class.

Feel free to make a PR with a proper fix if you feel like it.

@VincentX0905
Copy link

e any questions please open an issue in my repository I will try to update to 1.21.4 in the next few days

In versions after 1.20.5, PaperMC has removed the NM

Hello Vincent, i totally missed papers announcement about that one. There is currently a dev branch that had working plugin, I lack the time to look into some other isssues aswel for example the nms location of craftplayer class.

Feel free to make a PR with a proper fix if you feel like it.

@Jens-Co Hello!
I only did a hotfix, this is not a long-term solution.
https://github.com/VincentX0905/CrossplatForms-new/blob/e71ecdf1fc6daa867f041ac9dafb7a7062fef218/spigot-common/common/src/main/java/dev/kejona/crossplatforms/spigot/ClassNames.java#L26-L45
You need to find a NMS plugin for gradle or some other solution (maybe remove NMS?) for a long term solution

@VincentX0905
Copy link

#211

@VincentX0905
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants
@ZherKing @Jens-Co @DBTDerpbox @MiguVT @Konicai @wykwey @VincentX0905 and others