Skip to content

btrfs restore prints "offset is " messages, even without verbose option #920

@keestux

Description

@keestux

When I run btrfs restore without verbose option it prints lines like these:

$ sudo btrfs restore --root 4339 --snapshots --metadata --symlinks --ignore-errors /dev/sdc2 /tmp/my-restored-subvol
offset is 4096
offset is 8192
offset is 36864
offset is 4096
offset is 53248
offset is 4096

There is no documentation what these messages mean. Is it an error? Is it a message that should only be given with verbose option?

It is from line 394 in cmds/restore.c

	pr_verbose(offset ? 1 : 0, "offset is %llu\n", offset);

Perhaps the 1 should probably have been LOG_INFO. No?

Besides, it would be useful for the user to know what this message means.

Metadata

Metadata

Assignees

No one assigned

    Labels

    UI/UXUser interface changebug

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions