-
Notifications
You must be signed in to change notification settings - Fork 9
Remove scheme validation & refac apiexport #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @EpicStep. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Stepan Rabotkin <[email protected]>
29b2ac5 to
1a134c9
Compare
|
/ok-to-test |
|
/kind cleanup |
| // Do the defaulting controller-runtime would do for those fields we need. | ||
| if options.Scheme == nil { | ||
| return nil, fmt.Errorf("scheme must be provided") | ||
| options.Scheme = scheme.Scheme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is open to discussion. The problem is that if one uses a dedicated schema object when initialising this code, it will not work as the schemas will not match. So, should we be explicit here and ask the user to provide the schema, or are we ok?
Summary
I removed the validation for the scheme option since the Options docs say it uses the default scheme from client-go. If this behavior changed after the last PR, please let me know and I’ll update the docs. Also did a bit of refactoring.
What Type of PR Is This?
/kind cleanup
Related Issue(s)
Release Notes