Skip to content

Commit e141e5c

Browse files
committed
refactor: vet cli using the validate API
Signed-off-by: peefy <[email protected]>
1 parent 791f875 commit e141e5c

File tree

3 files changed

+12
-16
lines changed

3 files changed

+12
-16
lines changed

cmd/kcl/commands/vet.go

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -57,16 +57,16 @@ func NewVetCmd() *cobra.Command {
5757

5858
func doValidate(dataFile, codeFile string, o *validate.ValidateOptions) error {
5959
var ok bool
60-
code, err := os.ReadFile(codeFile)
61-
if err != nil {
62-
return err
63-
}
6460
if dataFile == "-" {
6561
// Read data from stdin
6662
input, err := io.ReadAll(os.Stdin)
6763
if err != nil {
6864
return err
6965
}
66+
code, err := os.ReadFile(codeFile)
67+
if err != nil {
68+
return err
69+
}
7070
ok, err = validate.ValidateCode(string(input), string(code), o)
7171
if err != nil {
7272
return err
@@ -78,18 +78,14 @@ func doValidate(dataFile, codeFile string, o *validate.ValidateOptions) error {
7878
return err
7979
}
8080
for _, dataFile := range dataFiles {
81-
data, err := os.ReadFile(dataFile)
82-
if err != nil {
83-
return err
84-
}
85-
ok, err = validate.ValidateCode(string(data), string(code), o)
81+
ok, err = validate.Validate(dataFile, codeFile, o)
8682
if err != nil {
8783
return err
8884
}
8985
}
9086
}
9187
if ok {
92-
fmt.Println("Validate success")
88+
fmt.Println("Validate success!")
9389
}
9490
return nil
9591
}

go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ go 1.19
55
require (
66
github.com/acarl005/stripansi v0.0.0-20180116102854-5a71ef0e047d
77
github.com/spf13/cobra v1.7.0
8-
kcl-lang.io/kcl-go v0.7.0-beta.1.0.20231127032754-434db4c2e176
8+
kcl-lang.io/kcl-go v0.7.0-beta.1.0.20231129132340-83897a56d087
99
kcl-lang.io/kcl-openapi v0.5.2-0.20231116071001-d8316c05cd2d
1010
kcl-lang.io/kcl-playground v0.5.1-0.20230919072953-347ab8959295
1111
kcl-lang.io/kpm v0.4.1
@@ -81,7 +81,7 @@ require (
8181
k8s.io/klog/v2 v2.100.1 // indirect
8282
k8s.io/kube-openapi v0.0.0-20230717233707-2695361300d9 // indirect
8383
k8s.io/utils v0.0.0-20230406110748-d93618cff8a2 // indirect
84-
kcl-lang.io/kcl-artifact-go v0.7.0-beta.1 // indirect
84+
kcl-lang.io/kcl-artifact-go v0.7.0-beta.2 // indirect
8585
sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect
8686
sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect
8787
sigs.k8s.io/yaml v1.3.0 // indirect

go.sum

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1284,10 +1284,10 @@ k8s.io/utils v0.0.0-20210802155522-efc7438f0176/go.mod h1:jPW/WVKK9YHAvNhRxK0md/
12841284
k8s.io/utils v0.0.0-20220210201930-3a6ce19ff2f9/go.mod h1:jPW/WVKK9YHAvNhRxK0md/EJ228hCsBRufyofKtW8HA=
12851285
k8s.io/utils v0.0.0-20230406110748-d93618cff8a2 h1:qY1Ad8PODbnymg2pRbkyMT/ylpTrCM8P2RJ0yroCyIk=
12861286
k8s.io/utils v0.0.0-20230406110748-d93618cff8a2/go.mod h1:OLgZIPagt7ERELqWJFomSt595RzquPNLL48iOWgYOg0=
1287-
kcl-lang.io/kcl-artifact-go v0.7.0-beta.1 h1:u1l/OXWblOiDHabN+6ApSHTZwNyOskuOCf90fXreGu4=
1288-
kcl-lang.io/kcl-artifact-go v0.7.0-beta.1/go.mod h1:c07mqi9Hu2UjPW7lYfHhAAWOlZiB7lo7Vkr4jL5ov/M=
1289-
kcl-lang.io/kcl-go v0.7.0-beta.1.0.20231127032754-434db4c2e176 h1:CG59UuhIAH30Fj0mEYxn2bokHi/+UWjqop2WINOfRtQ=
1290-
kcl-lang.io/kcl-go v0.7.0-beta.1.0.20231127032754-434db4c2e176/go.mod h1:yf8pMkic+1m4wedG9MLxrkeVoqFhIrMbY+x4nPPg2O8=
1287+
kcl-lang.io/kcl-artifact-go v0.7.0-beta.2 h1:7L5qbEqD8y672XNTk2snv8/UXScABFdM3g9Bu2Ama1Q=
1288+
kcl-lang.io/kcl-artifact-go v0.7.0-beta.2/go.mod h1:c07mqi9Hu2UjPW7lYfHhAAWOlZiB7lo7Vkr4jL5ov/M=
1289+
kcl-lang.io/kcl-go v0.7.0-beta.1.0.20231129132340-83897a56d087 h1:shfYD/EiBuacHQJ63XuM7X1OgieiyfaqrpqhU0ECVCE=
1290+
kcl-lang.io/kcl-go v0.7.0-beta.1.0.20231129132340-83897a56d087/go.mod h1:dxF3hghkxoJKOkBrXwrqc8nRT0HylrOvsI83FxdQT6M=
12911291
kcl-lang.io/kcl-openapi v0.5.2-0.20231116071001-d8316c05cd2d h1:wbaI/FjzeMbzFGEjzBBA4o5AotRAy376IoHXZh/oNJQ=
12921292
kcl-lang.io/kcl-openapi v0.5.2-0.20231116071001-d8316c05cd2d/go.mod h1:Ai9mFztCVKkRSFabczO/r5hCNdqaNtAc2ZIRxTeV0Mk=
12931293
kcl-lang.io/kcl-playground v0.5.1-0.20230919072953-347ab8959295 h1:RUY3w6jNAB6GoMo27CO1oS4C4gjyWdMXfOTNpTEnkjs=

0 commit comments

Comments
 (0)