Add tests for Stringable implementation in Serializers

Author: Art4

tests/Unit/Serializer/JsonSerializerTest.php

@@ -180,21 +180,17 @@ public static function getNormalizedToEncodedData(): array
     }
 
     /**
+     * @covers \Redmine\Serializer\JsonSerializer::getEncoded
+     * @covers \Redmine\Serializer\JsonSerializer::__toString
      * @test
      *
      * @dataProvider getNormalizedToEncodedData
      */
-    public function createFromArrayDecodesToExpectedString(array $data, $expected)
+    public function createFromArrayEncodesToExpectedString(array $data, $expected)
     {
         $serializer = JsonSerializer::createFromArray($data);
 
-        // decode the result, so we encode again with JSON_PRETTY_PRINT to compare the formated output
-        $encoded = json_encode(
-            json_decode($serializer->getEncoded(), true, 512, \JSON_THROW_ON_ERROR),
-            \JSON_THROW_ON_ERROR | \JSON_PRETTY_PRINT
-        );
-
-        $this->assertSame($expected, $encoded);
+        $this->assertJsonStringEqualsJsonString($expected, $serializer->__toString());
     }
 
     public static function getInvalidSerializedData(): array

tests/Unit/Serializer/PathSerializerTest.php

@@ -48,6 +48,8 @@ public static function getPathData(): array
     }
 
     /**
+     * @covers \Redmine\Serializer\PathSerializer::getPath
+     * @covers \Redmine\Serializer\PathSerializer::__toString
      * @test
      *
      * @dataProvider getPathData
@@ -56,6 +58,6 @@ public function getPathShouldReturnExpectedString(string $path, array $params, s
     {
         $serializer = PathSerializer::create($path, $params);
 
-        $this->assertSame($expected, $serializer->getPath());
+        $this->assertSame($expected, $serializer->__toString());
     }
 }

tests/Unit/Serializer/XmlSerializerTest.php

@@ -186,19 +186,17 @@ public static function getNormalizedToEncodedData(): array
     }
 
     /**
+     * @covers \Redmine\Serializer\XmlSerializer::getEncoded
+     * @covers \Redmine\Serializer\XmlSerializer::__toString
      * @test
      *
      * @dataProvider getNormalizedToEncodedData
      */
-    public function createFromArrayDecodesToExpectedString(array $data, $expected)
+    public function createFromArrayEncodesToExpectedString(array $data, $expected)
     {
         $serializer = XmlSerializer::createFromArray($data);
 
-        // Load the encoded string into a DOMDocument, so we can compare the formated output
-        $dom = dom_import_simplexml(new \SimpleXMLElement($serializer->getEncoded()))->ownerDocument;
-        $dom->formatOutput = true;
-
-        $this->assertSame($expected, trim($dom->saveXML()));
+        $this->assertXmlStringEqualsXmlString($expected, $serializer->__toString());
     }
 
     public static function getInvalidSerializedData(): array